From: "tip-bot2 for Brian Norris" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Guenter Roeck <linux@roeck-us.net>,
Brian Norris <briannorris@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
David Gow <davidgow@google.com>,
x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org
Subject: [tip: irq/core] genirq/test: Drop CONFIG_GENERIC_IRQ_MIGRATION assumptions
Date: Wed, 03 Sep 2025 15:12:28 -0000 [thread overview]
Message-ID: <175691234810.1920.10556521436506250097.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250822190140.2154646-6-briannorris@chromium.org>
The following commit has been merged into the irq/core branch of tip:
Commit-ID: add03fdb9d52411cabb3872fb7692df6f4c67586
Gitweb: https://git.kernel.org/tip/add03fdb9d52411cabb3872fb7692df6f4c67586
Author: Brian Norris <briannorris@chromium.org>
AuthorDate: Fri, 22 Aug 2025 11:59:06 -07:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 03 Sep 2025 17:04:52 +02:00
genirq/test: Drop CONFIG_GENERIC_IRQ_MIGRATION assumptions
Not all platforms use the generic IRQ migration code, even if they select
GENERIC_IRQ_MIGRATION. (See, for example, powerpc / pseries_cpu_disable().)
If such platforms don't perform managed shutdown the same way, the interrupt
may not actually shut down, and these tests fail:
[ 4.357022][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:211
[ 4.357022][ T101] Expected irqd_is_activated(data) to be false, but is true
[ 4.358128][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:212
[ 4.358128][ T101] Expected irqd_is_started(data) to be false, but is true
[ 4.375558][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:216
[ 4.375558][ T101] Expected irqd_is_activated(data) to be false, but is true
[ 4.376088][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:217
[ 4.376088][ T101] Expected irqd_is_started(data) to be false, but is true
[ 4.377851][ T1] # irq_cpuhotplug_test: pass:0 fail:1 skip:0 total:1
[ 4.377901][ T1] not ok 4 irq_cpuhotplug_test
[ 4.378073][ T1] # irq_test_cases: pass:3 fail:1 skip:0 total:4
Rather than test that PowerPC performs migration the same way as the
unterrupt core, just drop the state checks. The point of the test was to
ensure that the code kept |depth| balanced, which still can be tested for.
Fixes: 66067c3c8a1e ("genirq: Add kunit tests for depth counts")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: David Gow <davidgow@google.com>
Link: https://lore.kernel.org/all/20250822190140.2154646-6-briannorris@chromium.org
---
kernel/irq/irq_test.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kernel/irq/irq_test.c b/kernel/irq/irq_test.c
index 56baeb5..bbb89a3 100644
--- a/kernel/irq/irq_test.c
+++ b/kernel/irq/irq_test.c
@@ -203,13 +203,9 @@ static void irq_cpuhotplug_test(struct kunit *test)
KUNIT_EXPECT_EQ(test, desc->depth, 1);
KUNIT_EXPECT_EQ(test, remove_cpu(1), 0);
- KUNIT_EXPECT_FALSE(test, irqd_is_activated(data));
- KUNIT_EXPECT_FALSE(test, irqd_is_started(data));
KUNIT_EXPECT_GE(test, desc->depth, 1);
KUNIT_EXPECT_EQ(test, add_cpu(1), 0);
- KUNIT_EXPECT_FALSE(test, irqd_is_activated(data));
- KUNIT_EXPECT_FALSE(test, irqd_is_started(data));
KUNIT_EXPECT_EQ(test, desc->depth, 1);
enable_irq(virq);
next prev parent reply other threads:[~2025-09-03 15:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 18:59 [PATCH v2 0/6] genirq/test: Platform/architecture fixes Brian Norris
2025-08-22 18:59 ` [PATCH v2 1/6] genirq/test: Select IRQ_DOMAIN Brian Norris
2025-08-23 1:13 ` Guenter Roeck
2025-09-03 15:12 ` [tip: irq/core] " tip-bot2 for Brian Norris
2025-08-22 18:59 ` [PATCH v2 2/6] genirq/test: Factor out fake-virq setup Brian Norris
2025-08-23 1:13 ` Guenter Roeck
2025-09-03 15:12 ` [tip: irq/core] " tip-bot2 for Brian Norris
2025-08-22 18:59 ` [PATCH v2 3/6] genirq/test: Fail early if we can't request an IRQ Brian Norris
2025-08-23 1:13 ` Guenter Roeck
2025-09-03 15:12 ` [tip: irq/core] genirq/test: Fail early if interrupt request fails tip-bot2 for Brian Norris
2025-08-22 18:59 ` [PATCH v2 4/6] genirq/test: Depend on SPARSE_IRQ Brian Norris
2025-08-23 1:13 ` Guenter Roeck
2025-08-23 6:59 ` David Gow
2025-08-25 21:23 ` Brian Norris
2025-09-03 15:12 ` [tip: irq/core] " tip-bot2 for Brian Norris
2025-08-22 18:59 ` [PATCH v2 5/6] genirq/test: Drop CONFIG_GENERIC_IRQ_MIGRATION assumptions Brian Norris
2025-08-23 1:13 ` Guenter Roeck
2025-09-03 15:12 ` tip-bot2 for Brian Norris [this message]
2025-08-22 18:59 ` [PATCH v2 6/6] genirq/test: Ensure CPU 1 is online for hotplug test Brian Norris
2025-08-23 1:14 ` Guenter Roeck
2025-09-03 15:12 ` [tip: irq/core] " tip-bot2 for Brian Norris
2025-08-22 23:26 ` [PATCH v2 0/6] genirq/test: Platform/architecture fixes Guenter Roeck
2025-08-23 1:15 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175691234810.1920.10556521436506250097.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=briannorris@chromium.org \
--cc=davidgow@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).