From: Oliver Upton <oliver.upton@linux.dev>
To: kvmarm@lists.linux.dev, Geonha Lee <w1nsom3gna@korea.ac.kr>
Cc: Oliver Upton <oliver.upton@linux.dev>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH] KVM: arm64: nested: fix VNCR TLB ASID match logic for non-Global entries
Date: Fri, 5 Sep 2025 02:41:10 -0700 [thread overview]
Message-ID: <175706523473.1669883.17269564627952159753.b4-ty@linux.dev> (raw)
In-Reply-To: <20250903150421.90752-1-w1nsom3gna@korea.ac.kr>
On Thu, 04 Sep 2025 00:04:21 +0900, Geonha Lee wrote:
> kvm_vncr_tlb_lookup() is supposed to return true when the cached VNCR
> TLB entry is valid for the current context. For non-Global entries, that
> means the entry’s ASID must match the current ASID.
>
> The current code returns true when the ASIDs do *not* match, which
> inverts the logic. This is a potential vulnerability:
>
> [...]
Applied to fixes, thanks!
[1/1] KVM: arm64: nested: fix VNCR TLB ASID match logic for non-Global entries
https://git.kernel.org/kvmarm/kvmarm/c/06f66db9bda4
--
Best,
Oliver
prev parent reply other threads:[~2025-09-05 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 15:04 [PATCH] KVM: arm64: nested: fix VNCR TLB ASID match logic for non-Global entries Geonha Lee
2025-09-04 9:32 ` Marc Zyngier
2025-09-05 9:41 ` Oliver Upton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175706523473.1669883.17269564627952159753.b4-ty@linux.dev \
--to=oliver.upton@linux.dev \
--cc=catalin.marinas@arm.com \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=w1nsom3gna@korea.ac.kr \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).