The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Zhangchao Zhang <ot_zhangchao.zhang@mediatek.com>
Cc: Chris Lu <chris.lu@mediatek.com>,
	 linux-mediatek <linux-mediatek@lists.infradead.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Sean Wang <sean.wang@mediatek.com>,
	Marcel Holtmann <marcel@holtmann.org>,
	 Jiande Lu <jiande.lu@mediatek.com>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 linux-bluetooth <linux-bluetooth@vger.kernel.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Hao Qin <Hao.qin@mediatek.com>,
	 Luiz Von Dentz <luiz.dentz@gmail.com>,
	 devicetree <devicetree@vger.kernel.org>,
	Deren Wu <deren.Wu@mediatek.com>
Subject: Re: [PATCH v7] dt-bindings: net: mediatek,mt7925-bluetooth.yaml
Date: Fri, 05 Sep 2025 10:02:57 -0500	[thread overview]
Message-ID: <175708448180.930634.147702031291534747.robh@kernel.org> (raw)
In-Reply-To: <20250905084433.26999-1-ot_zhangchao.zhang@mediatek.com>


On Fri, 05 Sep 2025 16:44:33 +0800, Zhangchao Zhang wrote:
> Reset BT via BT_KILL_1V2_L hardware pin.
> 
> On the M.2 standard hardware pin interface, the MTK chip
> has a pin called BT_KILL_1V2_L or W_DISABLE#2, it uses
> function-level device reset (FLDR) to reset Bluetooth.
> When it is pulled low, it can external shut down the BT
> function, it is defined as 5 on the MT7925 chip, and is
> defined as 248 on the device tree pio controller.
> 
> Signed-off-by: Zhangchao Zhang <ot_zhangchao.zhang@mediatek.com>
> ---
>  .../bluetooth/mediatek,mt7925-bluetooth.yaml  | 47 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  2 files changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7925-bluetooth.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7925-bluetooth.example.dtb: bluetooth (mediatek,mt7925-bluetooth): Unevaluated properties are not allowed ('#gpio-cells' was unexpected)
	from schema $id: http://devicetree.org/schemas/net/bluetooth/mediatek,mt7925-bluetooth.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250905084433.26999-1-ot_zhangchao.zhang@mediatek.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-09-05 15:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-05  8:44 [PATCH v7] dt-bindings: net: mediatek,mt7925-bluetooth.yaml Zhangchao Zhang
2025-09-05 15:02 ` Rob Herring (Arm) [this message]
2025-09-06  7:15 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175708448180.930634.147702031291534747.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Hao.qin@mediatek.com \
    --cc=chris.lu@mediatek.com \
    --cc=conor+dt@kernel.org \
    --cc=deren.Wu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jiande.lu@mediatek.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=ot_zhangchao.zhang@mediatek.com \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox