Re: [PATCH 2/2] net: mana: Add standard counter rx_missed_errors

Erni Sri Satya Vennela
2025-10-14T09:36:48Z

On Wed, Sep 24, 2025 at 09:24:05PM -0700, Erni Sri Satya Vennela wrote:
> On Tue, Sep 16, 2025 at 03:22:54PM +0200, Paolo Abeni wrote:
> > On 9/15/25 5:58 AM, Erni Sri Satya Vennela wrote:
> > > Report standard counter stats->rx_missed_errors
> > > using hc_rx_discards_no_wqe from the hardware.
> > >
> > > Add a dedicated workqueue to periodically run
> > > mana_query_gf_stats every 2 seconds to get the latest
> > > info in eth_stats and define a driver capability flag
> > > to notify hardware of the periodic queries.
> > >
> > > To avoid repeated failures and log flooding, the workqueue
> > > is not rescheduled if mana_query_gf_stats fails.
> >
> > Can the failure root cause be a "transient" one? If so, this looks like
> > a dangerous strategy; is such scenario, AFAICS, stats will be broken
> > until the device is removed and re-probed.
> >
> > /P
Hi Paolo,
I wanted to follow up on the clarification I shared regarding my
patch. Please let me know if there's anything further needed from my
side.

- Vennela