From: Johannes Berg <johannes@sipsolutions.net>
To: Ramon Fontes <ramonreisfontes@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-wireless <linux-wireless@vger.kernel.org>,
kvalo@codeaurora.org, davem@davemloft.net
Subject: Re: [PATCH] mac80211_hwsim: set the maximum EIRP output power for 5GHz
Date: Fri, 22 Nov 2019 18:52:12 +0100 [thread overview]
Message-ID: <175edd72f0cd3bc4d2c0dbd42a4570c7fb47b8fd.camel@sipsolutions.net> (raw)
In-Reply-To: <CAK8U23aL7UDgko4Z2EkQ9r4muBTjNOCq-Erb9h2TFRnxdOmtWg@mail.gmail.com> (sfid-20191122_151928_905345_8C817F08)
On Fri, 2019-11-22 at 11:19 -0300, Ramon Fontes wrote:
> > Right, so the commit log should say that it should be incremented to
> > allow regdb to work, rather than worry about ETSI specifics?
> >
> > Or maybe this limit should just be removed entirely?
>
> Hmm.. not sure. Perhaps we should add only one more information:
>
> ETSI has been set the maximum EIRP output power to 36 dBm (4000 mW)
> Source: https://www.etsi.org/deliver/etsi_en/302500_302599/302502/01.02.01_60/en_302502v010201p.pdf
>
> + The new maximum EIRP output power also allows regdb to work
> correctly when txpower is greater than 20 dBm.
>
> Since there is no standard defining greater txpower, in my opinion we
> should keep the maximum value. What do you think?
It just feels to me like if the only restriction in the driver is
regulatory, we shouldn't have it in the driver. That's what we have the
regulatory database for.
If there's some other (physical?) restriction in the driver, sure, maybe
it should have one there, but for pure regulatory I'm not sure I see it.
That's why the pointer here to ETSI feels so strange to me.
> Do I need to submit a new patch?
I'll need to see if we can remove it, but if we can I'll do that, and
otherwise I can just commit your patch but with a changed commit
message.
Note that I just sent my final pull request for the current kernel, so
this'll probably have to wait some time.
johannes
next prev parent reply other threads:[~2019-11-22 18:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 15:20 [PATCH] mac80211_hwsim: set the maximum EIRP output power for 5GHz Ramon Fontes
2019-11-22 11:41 ` Johannes Berg
2019-11-22 12:52 ` Ramon Fontes
2019-11-22 13:02 ` Johannes Berg
2019-11-22 14:19 ` Ramon Fontes
2019-11-22 17:52 ` Johannes Berg [this message]
2019-11-22 18:07 ` Ramon Fontes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175edd72f0cd3bc4d2c0dbd42a4570c7fb47b8fd.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ramonreisfontes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox