public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: dhowells@redhat.com, Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <andi@firstfloor.org>,
	Neil Horman <nhorman@tuxdriver.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 1/2] umh && creds: convert call_usermodehelper_keys() to use subprocess_info->init()
Date: Fri, 26 Feb 2010 18:41:08 +0000	[thread overview]
Message-ID: <17603.1267209668@redhat.com> (raw)
In-Reply-To: <20100226182325.GA31674@redhat.com>

Oleg Nesterov <oleg@redhat.com> wrote:

> How? Without CLONE_THREAD copy_creds() always creates the new
> struct cred for the child?

Okay, that's a good point.

In which case, you should be calling install_session_keyring_to_cred(), just
so that the credentials installation is always done by the same piece of code.

David

  reply	other threads:[~2010-02-26 18:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-25 18:15 [PATCH -mm 1/2] umh && creds: convert call_usermodehelper_keys() to use subprocess_info->init() Oleg Nesterov
2010-02-26 18:00 ` David Howells
2010-02-26 18:23   ` Oleg Nesterov
2010-02-26 18:41     ` David Howells [this message]
2010-02-26 18:52       ` Oleg Nesterov
2010-02-26 20:03       ` [PATCH v2 -mm 0/2] umh && creds: kill sub_info->cred Oleg Nesterov
2010-02-26 20:03         ` [PATCH v2 -mm 1/2] umh && creds: convert call_usermodehelper_keys() to use subprocess_info->init() Oleg Nesterov
2010-02-26 20:28           ` Neil Horman
2010-02-26 20:42           ` David Howells
2010-02-26 20:53             ` Oleg Nesterov
2010-02-26 23:24               ` David Howells
2010-03-05 22:52                 ` Oleg Nesterov
2010-03-05 23:09                   ` [PATCH,RESEND " Oleg Nesterov
2010-03-08 13:19                     ` David Howells
2010-03-08 17:44                     ` Neil Horman
2010-03-05 23:10                   ` [PATCH,RESEND -mm 2/2] umh && creds: kill subprocess_info->cred logic Oleg Nesterov
2010-03-08 13:19                     ` David Howells
2010-03-08 17:47                     ` Neil Horman
2010-02-26 20:04         ` [PATCH v2 " Oleg Nesterov
2010-02-26 20:29           ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17603.1267209668@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox