From: patchwork-bot+netdevbpf@kernel.org
To: Ilya Maximets <i.maximets@ovn.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
linux-kernel@vger.kernel.org, dev@openvswitch.org,
echaudro@redhat.com, aconole@redhat.com, w@1wt.eu,
kwqcheii@proton.me, zhuque@tencent.com
Subject: Re: [PATCH net] net: openvswitch: remove never-working support for setting nsh fields
Date: Sat, 15 Nov 2025 02:20:12 +0000 [thread overview]
Message-ID: <176317321200.1911668.558293719970758983.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20251112112246.95064-1-i.maximets@ovn.org>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 12 Nov 2025 12:14:03 +0100 you wrote:
> The validation of the set(nsh(...)) action is completely wrong.
> It runs through the nsh_key_put_from_nlattr() function that is the
> same function that validates NSH keys for the flow match and the
> push_nsh() action. However, the set(nsh(...)) has a very different
> memory layout. Nested attributes in there are doubled in size in
> case of the masked set(). That makes proper validation impossible.
>
> [...]
Here is the summary with links:
- [net] net: openvswitch: remove never-working support for setting nsh fields
https://git.kernel.org/netdev/net/c/dfe28c4167a9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-11-15 2:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 11:14 [PATCH net] net: openvswitch: remove never-working support for setting nsh fields Ilya Maximets
2025-11-12 13:28 ` Eelco Chaudron
2025-11-12 14:55 ` Aaron Conole
2025-11-12 15:02 ` Ilya Maximets
2025-11-15 2:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176317321200.1911668.558293719970758983.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=kuba@kernel.org \
--cc=kwqcheii@proton.me \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=w@1wt.eu \
--cc=zhuque@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox