From: patchwork-bot+netdevbpf@kernel.org
To: Breno Leitao <leitao@debian.org>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, gustavold@gmail.com,
asantostc@gmail.com, kernel-team@meta.com
Subject: Re: [PATCH net] net: netpoll: initialize work queue before error checks
Date: Sat, 29 Nov 2025 04:30:18 +0000 [thread overview]
Message-ID: <176439061855.907626.14454545998670880238.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20251127-netpoll_fix_init_work-v1-1-65c07806d736@debian.org>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 27 Nov 2025 07:30:15 -0800 you wrote:
> Prevent a kernel warning when netconsole setup fails on devices with
> IFF_DISABLE_NETPOLL flag. The warning (at kernel/workqueue.c:4242 in
> __flush_work) occurs because the cleanup path tries to cancel an
> uninitialized work queue.
>
> When __netpoll_setup() encounters a device with IFF_DISABLE_NETPOLL,
> it fails early and calls skb_pool_flush() for cleanup. This function
> calls cancel_work_sync(&np->refill_wq), but refill_wq hasn't been
> initialized yet, triggering the warning.
>
> [...]
Here is the summary with links:
- [net] net: netpoll: initialize work queue before error checks
https://git.kernel.org/netdev/net/c/e5235eb6cfe0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-11-29 4:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 15:30 [PATCH net] net: netpoll: initialize work queue before error checks Breno Leitao
2025-11-29 4:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176439061855.907626.14454545998670880238.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=asantostc@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavold@gmail.com \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox