public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Biju <biju.das.au@gmail.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	Jiri Slaby <jirislaby@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Geert Uytterhoeven <geert+renesas@glider.be>,
	 Biju Das <biju.das.jz@bp.renesas.com>,
	 Wolfram Sang <wsa+renesas@sang-engineering.com>,
	 linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Conor Dooley <conor+dt@kernel.org>,
	 Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v5 01/17] dt-bindings: serial: renesas,rsci: Document RZ/G3E support
Date: Sat, 29 Nov 2025 11:23:13 -0600	[thread overview]
Message-ID: <176443699313.11808.1467058497468917565.robh@kernel.org> (raw)
In-Reply-To: <20251129164325.209213-2-biju.das.jz@bp.renesas.com>


On Sat, 29 Nov 2025 16:42:57 +0000, Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Add documentation for the serial communication interface (RSCI) found on
> the Renesas RZ/G3E (R9A09G047) SoC. The RSCI IP on this SoC is identical
> to that on the RZ/T2H (R9A09G077) SoC, but it has a 32-stage FIFO compared
> to 16 on RZ/T2H. It supports both FIFO and non-FIFO mode operation. RZ/G3E
> has 6 clocks(5 module clocks + 1 external clock) compared to 3 clocks
> (2 module clocks + 1 external clock) on RZ/T2H, and it has multiple resets.
> It has 6 interrupts compared to 4 on RZ/T2H.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v4->v5:
>  * Updated commit description related to IRQ difference
>  * Added aed and bfd irqs for RZ/G3E.
>  * Moved reset: false to RZ/T2H SoC and dropped the else part for RZ/G3E.
>  * Updated conditional schema with interrupts and interrupts-names.
>  * Dropped the tag as there are new changes.
> v3->v4:
>  * Dropped separate compatible for non-FIFO mode and instead using single
>    compatible "renesas,r9a09g047-rsci" as non-FIFO mode can be achieved
>    by software configuration.
>  * Renamed clock-names bus->pclk
>  * Rearranged clock-names tclk{4, 16, 64}
>  * Retained the tag as the changes are trivial.
> v2->v3:
>  * Dropped 1st and 3rd items from clk-names and added minItems for the
>    range.
>  * Added minItems for clk and clk-names for RZ/T2H as the range is 2-3
>  * Added maxItems for clk and clk-names for RZ/G3E as the range is 5-6
>  * Retained the tag as it is trivial change.
> v1->v2:
>  * Updated commit message
>  * Added resets:false for non RZ/G3E SoCs.
> ---
>  .../bindings/serial/renesas,rsci.yaml         | 99 ++++++++++++++++---
>  1 file changed, 88 insertions(+), 11 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/thermal/thermal-zones.example.dtb: /example-0/soc/thermal-sensor@c263000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
Documentation/devicetree/bindings/thermal/thermal-zones.example.dtb: /example-0/soc/thermal-sensor@c263000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
Documentation/devicetree/bindings/thermal/thermal-zones.example.dtb: /example-0/soc/thermal-sensor@c265000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
Documentation/devicetree/bindings/thermal/thermal-zones.example.dtb: /example-0/soc/thermal-sensor@c265000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c263000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c263000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c265000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@c265000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251129164325.209213-2-biju.das.jz@bp.renesas.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-11-29 17:23 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-29 16:42 [PATCH v5 00/17] Add RZ/G3E RSCI support Biju
2025-11-29 16:42 ` [PATCH v5 01/17] dt-bindings: serial: renesas,rsci: Document RZ/G3E support Biju
2025-11-29 17:23   ` Rob Herring (Arm) [this message]
2025-12-03  8:13     ` Biju Das
2025-12-04  8:00       ` Krzysztof Kozlowski
2025-12-04  8:03   ` Krzysztof Kozlowski
2025-12-04  8:23     ` Biju Das
2025-12-09 19:02       ` Rob Herring
2025-11-29 16:42 ` [PATCH v5 02/17] serial: sh-sci: Update rx_trigger size for RZ/T2H RSCI Biju
2025-11-29 16:42 ` [PATCH v5 03/17] serial: rsci: Add set_rtrg() callback Biju
2025-12-22 14:05   ` Geert Uytterhoeven
2025-12-22 14:30     ` Biju Das
2025-11-29 16:43 ` [PATCH v5 04/17] serial: sh-sci: Drop checking port type for device file{create, remove} Biju
2025-11-29 16:43 ` [PATCH v5 05/17] serial: rsci: Drop rsci_clear_SCxSR() Biju
2025-11-29 16:43 ` [PATCH v5 06/17] serial: sh-sci: Drop extra lines Biju
2025-11-29 16:43 ` [PATCH v5 07/17] serial: rsci: Drop unused macro DCR Biju
2025-11-29 16:43 ` [PATCH v5 08/17] serial: rsci: Drop unused TDR register Biju
2025-11-29 16:43 ` [PATCH v5 09/17] serial: sh-sci: Use devm_reset_control_array_get_exclusive() Biju
2025-11-29 16:43 ` [PATCH v5 10/17] serial: sh-sci: Add sci_is_rsci_type() Biju
2025-11-29 16:43 ` [PATCH v5 11/17] serial: sh-sci: Rename port SCI_PORT_RSCI->RSCI_PORT_SCIF16 Biju
2025-11-29 16:43 ` [PATCH v5 12/17] serial: sh-sci: Add RSCI_PORT_SCIF32 port ID Biju
2025-11-29 16:43 ` [PATCH v5 13/17] serial: sh-sci: Add support for RZ/G3E RSCI clks Biju
2025-11-29 16:43 ` [PATCH v5 14/17] serial: sh-sci: Make sci_scbrr_calc() public Biju
2025-11-29 16:43 ` [PATCH v5 15/17] serial: sh-sci: Add finish_console_write() callback Biju
2025-11-29 16:43 ` [PATCH v5 16/17] serial: rsci: Rename early_console data, port_params and callback() names Biju
2025-11-29 16:43 ` [PATCH v5 17/17] serial: sh-sci: Add support for RZ/G3E RSCI Biju
2025-12-02 17:20 ` [PATCH v5 00/17] Add RZ/G3E RSCI support Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176443699313.11808.1467058497468917565.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=biju.das.au@gmail.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox