RE: [PATCH] scsi: storvsc: Process unsupported MODE_SENSE_10

Michael Kelley
2026-01-09T17:48:43Z

From: longli@linux.microsoft.com <longli@linux.microsoft.com> Sent: Wednesday, January 7, 2026 11:57 AM
>
> The Hyper-V host does not support MODE_SENSE_10 and MODE_SENSE.
> The driver handles MODE_SENSE as unsupported command, but not for
> MODE_SENSE_10. Add MODE_SENSE_10 to the same handling logic and
> return correct code to SCSI layer.
>
> Fixes: 89ae7d709357 ("Staging: hv: storvsc: Move the storage driver out of the staging area")
> Cc: stable@kernel.org
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
> drivers/scsi/storvsc_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 6e4112143c76..9b15784e2d64 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1154,6 +1154,7 @@ static void storvsc_on_io_completion(struct storvsc_device
> *stor_device,
>
> if ((stor_pkt->vm_srb.cdb[0] == INQUIRY) ||
> (stor_pkt->vm_srb.cdb[0] == MODE_SENSE) ||
> + (stor_pkt->vm_srb.cdb[0] == MODE_SENSE_10) ||
> (stor_pkt->vm_srb.cdb[0] == MAINTENANCE_IN &&
> hv_dev_is_fc(device))) {
> vstor_packet->vm_srb.scsi_status = 0;

There's a code comment above this "if" statement that describes the situation.
The comment specifically lists INQUIRY, MODE_SENSE, and MAINTENANCE_IN. For
consistency, it should be updated to include MODE_SENSE_10.

With the comment updated,

Reviewed-by: Michael Kelley <mhklinux@outlook.com>