From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756006AbcHXWZR (ORCPT ); Wed, 24 Aug 2016 18:25:17 -0400 Received: from gloria.sntech.de ([95.129.55.99]:44074 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752214AbcHXWZQ (ORCPT ); Wed, 24 Aug 2016 18:25:16 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Douglas Anderson Cc: linux-rockchip@lists.infradead.org, zhengxing@rock-chips.com, mturquette@baylibre.com, sboyd@codeaurora.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: rockchip: mark aclk_emmc_noc as a critical clock on rk3399 Date: Thu, 25 Aug 2016 00:25:03 +0200 Message-ID: <1770264.XeNEc6mIDD@diego> User-Agent: KMail/4.14.10 (Linux/4.6.0-1-amd64; KDE/4.14.22; x86_64; ; ) In-Reply-To: <1472063379-717-1-git-send-email-dianders@chromium.org> References: <1472063379-717-1-git-send-email-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 24. August 2016, 11:29:39 schrieb Douglas Anderson: > From: Xing Zheng > > We don't have code to handle any of the noc clocks in rk3399 and they're > all just listed as critical clocks. Let's do the same for > aclk_emmc_noc. > > Without this clock being marked as critical we have problems around > suspend/resume after commit 20c389e656a8 ("clk: rockchip: fix incorrect > aclk_emmc source gate bits on rk3399"). Before that change we were > presumably not actually gating any of these clocks because we were > setting the wrong gate. > > Signed-off-by: Xing Zheng > Signed-off-by: Douglas Anderson applied to my clk-fixes branch Thanks Heiko