public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: linux-kernel@vger.kernel.org
Subject: request_firmware() gives build failures
Date: Mon, 12 May 2008 15:48:23 -0600	[thread overview]
Message-ID: <17728.1210628903@vena.lwn.net> (raw)

Just tried building -rc2 (then current git) and got a few errors like:

  drivers/built-in.o: In function `generic_set_freq':
  tuner-xc2028.c:(.text+0x90f42): undefined reference to `request_firmware'
  tuner-xc2028.c:(.text+0x91418): undefined reference to `release_firmware'

A bit of digging turned up the problem: I had fw_loader configured as a
module, but some drivers which need it were configured built-in.  Don't
ask why I had those drivers configured in at all...time to prune that
.config I've been carrying around...

In any case, setting CONFIG_FW_LOADER=y makes the problem go away.  I'm
not good enough at kconfig to make that happen magically; putting in
"select FW_LOADER" doesn't seem to be enough.  In any case, given that
callers to request_firmware() can be built in, does it make sense to
have an option to make the firmware loader modular?

jon


             reply	other threads:[~2008-05-12 21:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-12 21:48 Jonathan Corbet [this message]
2008-05-13 20:43 ` request_firmware() gives build failures Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17728.1210628903@vena.lwn.net \
    --to=corbet@lwn.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox