public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	kbuild-all@01.org, Dan Williams <dan.j.williams@intel.com>,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: rcar-dmac: fix platform_no_drv_owner.cocci warnings
Date: Tue, 23 Dec 2014 10:49:17 +0200	[thread overview]
Message-ID: <17743667.Or7OWc9fBy@avalon> (raw)
In-Reply-To: <20141222151116.GK16827@intel.com>

Hi Vinod,

On Monday 22 December 2014 20:41:16 Vinod Koul wrote:
> On Thu, Dec 18, 2014 at 12:15:56PM +0800, kbuild test robot wrote:
> > drivers/dma/sh/rcar-dmac.c:1490:3-8: No need to set .owner here. The core
> > will do it.
> >
> > Remove .owner field if calls are used which set it automatically
> > 
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> > 
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> Laurent,
> 
> I am assuming you will apply/fold this one?

Done already.

> > ---
> > 
> >  rcar-dmac.c |    1 -
> >  1 file changed, 1 deletion(-)
> > 
> > --- a/drivers/dma/sh/rcar-dmac.c
> > +++ b/drivers/dma/sh/rcar-dmac.c
> > @@ -1487,7 +1487,6 @@ MODULE_DEVICE_TABLE(of, rcar_dmac_of_ids
> > 
> >  static struct platform_driver rcar_dmac_driver = {
> >  	.driver		= {
> > -		.owner	= THIS_MODULE,
> >  		.pm	= &rcar_dmac_pm,
> >  		.name	= "rcar-dmac",
> >  		.of_match_table = rcar_dmac_of_ids,

-- 
Regards,

Laurent Pinchart


      reply	other threads:[~2014-12-23  8:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201412181212.KWu8yaD9%fengguang.wu@intel.com>
2014-12-18  4:15 ` [PATCH] dmaengine: rcar-dmac: fix platform_no_drv_owner.cocci warnings kbuild test robot
2014-12-22 15:11   ` Vinod Koul
2014-12-23  8:49     ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17743667.Or7OWc9fBy@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox