Re: [PATCH] for_each_zone / for_each_pgdat

Linus Torvalds
2002-04-15T20:51:50Z

On Mon, 15 Apr 2002, Rik van Riel wrote:
> replace slightly obscure while loops with for_each_zone and
> for_each_pgdat macros, this version has the added optimisation
> of skipping empty zones (thanks to William Lee Irwin)

I'd suggest against making this kind of complicated inlien functions, and
I also don't see why the for_each_zone() isn't a simpler doubly nested
for-loop instead of being forced into a less obvious iterative loop?

In short, this looks syntactically simple, but the syntactic simplicity
comes at the expense of a unnecessarily complex implementation.

Linus