Re: [PATCH] for_each_zone / for_each_pgdat

Oliver Xymoron
2002-04-16T14:51:49Z

On Mon, 15 Apr 2002, Linus Torvalds wrote:

> On Mon, 15 Apr 2002, Linus Torvalds wrote:
> >
> > Which requires the user to use something like
> >
> > for_each_zone(zone) {
> > ...
> > } end_zone;
>
> Side note: I should probably have made this the standard notation for the
> "for_each_xxx ()" macros, because having an "end_xxx" macro means that you
> can start using things like "do { ... } while (x)" loops for the control
> flow, which is often easier for the compiler to optimize (ie if the first
> element is always valid, and you don't need a condition going in, which is
> often true).
>
> It does, of course, end up polluting the name-space a bit more.

Ugh. If we're going to use such ugly things, it would be nice if they were
do_zone/while_zone instead of being suggestive of a for loop.

--
"Love the dolphins," she advised him. "Write by W.A.S.T.E.."