From: Arnd Bergmann <arnd@arndb.de>
To: Gaston Gonzalez <gascoar@gmail.com>
Cc: gregkh@linuxfoundation.org, paul.gortmaker@windriver.com,
dilekuzulmez@gmail.com, gdonald@gmail.com,
cristina.opriceana@gmail.com, hamohammed.sa@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments
Date: Tue, 23 Jun 2015 12:13:47 +0200 [thread overview]
Message-ID: <1775494.ZyQRebyBWF@wuerfel> (raw)
In-Reply-To: <1434924729-21086-1-git-send-email-gascoar@gmail.com>
On Sunday 21 June 2015 19:12:09 Gaston Gonzalez wrote:
> /* WMM spec P.11: The minimum value for AIFSN shall be 2 */
> qos_param->aifs[aci] = (qos_param->aifs[aci] < 2) ? 2:qos_param->aifs[aci];
>
> - qos_param->cw_min[aci] = ac_params->ecw_min_max & 0x0F;
> + qos_param->cw_min[aci] =
> + cpu_to_le16(ac_params->ecw_min_max & 0x0F);
>
> - qos_param->cw_max[aci] = (ac_params->ecw_min_max & 0xF0) >> 4;
> + qos_param->cw_max[aci] =
> + cpu_to_le16((ac_params->ecw_min_max & 0xF0) >> 4);
>
> qos_param->flag[aci] =
> (ac_params->aci_aifsn & 0x10) ? 0x01 : 0x00;
> - qos_param->tx_op_limit[aci] = le16_to_cpu(ac_params->tx_op_limit);
> + qos_param->tx_op_limit[aci] = ac_params->tx_op_limit;
> }
> return 0;
This certainly needs a more thorough description of how you determined that
the byte swaps that you add are in fact required. Did you test it on
a big-endian machine?
Arnd
next prev parent reply other threads:[~2015-06-23 10:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-21 22:12 [PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments Gaston Gonzalez
2015-06-23 10:13 ` Arnd Bergmann [this message]
2015-06-24 16:34 ` Gaston Gonzalez
2015-06-25 12:06 ` Arnd Bergmann
2015-06-26 16:36 ` Gaston Gonzalez
2015-09-24 2:15 ` Gaston Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1775494.ZyQRebyBWF@wuerfel \
--to=arnd@arndb.de \
--cc=cristina.opriceana@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dilekuzulmez@gmail.com \
--cc=gascoar@gmail.com \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox