public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Sechang Lim <rhkrqnwk98@gmail.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
	andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com,
	song@kernel.org, yonghong.song@linux.dev,
	john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
	haoluo@google.com, jolsa@kernel.org, sun.jian.kdev@gmail.com,
	leon.hwang@linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf v4] bpf: Fix RCU stall in bpf_fd_array_map_clear()
Date: Fri, 10 Apr 2026 19:20:06 +0000	[thread overview]
Message-ID: <177584880680.2610429.13126828004209763320.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260407103823.3942156-1-rhkrqnwk98@gmail.com>

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Tue,  7 Apr 2026 10:38:23 +0000 you wrote:
> Add a missing cond_resched() in bpf_fd_array_map_clear() loop.
> 
> For PROG_ARRAY maps with many entries this loop calls
> prog_array_map_poke_run() per entry which can be expensive, and
> without yielding this can cause RCU stalls under load:
> 
>   rcu: INFO: rcu_preempt detected stalls on CPUs/tasks:
>   rcu: 	(detected by 0, t=6502 jiffies, g=729293, q=305 ncpus=1)
>   rcu: All QSes seen, last rcu_preempt kthread activity 6502 (4295096514-4295090012), jiffies_till_next_fqs=1, root ->qsmask 0x0
>   rcu: rcu_preempt kthread starved for 6502 jiffies! g729293 f0x2 RCU_GP_WAIT_FQS(5) ->state=0x0 ->cpu=0
>   rcu: 	Unless rcu_preempt kthread gets sufficient CPU time, OOM is now expected behavior.
>   rcu: RCU grace-period kthread stack dump:
>   task:rcu_preempt     state:R  running task     stack:0     pid:15    tgid:15    ppid:2      task_flags:0x208040 flags:0x00004000
>   Call Trace:
>    <TASK>
>    context_switch kernel/sched/core.c:5382 [inline]
>    __schedule+0x697/0x1430 kernel/sched/core.c:6767
>    __schedule_loop kernel/sched/core.c:6845 [inline]
>    schedule+0x10a/0x3e0 kernel/sched/core.c:6860
>    schedule_timeout+0x145/0x2c0 kernel/time/sleep_timeout.c:99
>    rcu_gp_fqs_loop+0x255/0x1350 kernel/rcu/tree.c:2046
>    rcu_gp_kthread+0x347/0x680 kernel/rcu/tree.c:2248
>    kthread+0x465/0x880 kernel/kthread.c:464
>    ret_from_fork+0x4d/0x80 arch/x86/kernel/process.c:153
>    ret_from_fork_asm+0x19/0x30 arch/x86/entry/entry_64.S:245
>    </TASK>
>   rcu: Stack dump where RCU GP kthread last ran:
>   CPU: 0 UID: 0 PID: 30932 Comm: kworker/0:2 Not tainted 6.14.0-13195-g967e8def1100 #2 PREEMPT(undef)
>   Hardware name: QEMU Ubuntu 24.04 PC v2 (i440FX + PIIX, arch_caps fix, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014
>   Workqueue: events prog_array_map_clear_deferred
>   RIP: 0010:write_comp_data+0x38/0x90 kernel/kcov.c:246
>   Call Trace:
>    <TASK>
>    prog_array_map_poke_run+0x77/0x380 kernel/bpf/arraymap.c:1096
>    __fd_array_map_delete_elem+0x197/0x310 kernel/bpf/arraymap.c:925
>    bpf_fd_array_map_clear kernel/bpf/arraymap.c:1000 [inline]
>    prog_array_map_clear_deferred+0x119/0x1b0 kernel/bpf/arraymap.c:1141
>    process_one_work+0x898/0x19d0 kernel/workqueue.c:3238
>    process_scheduled_works kernel/workqueue.c:3319 [inline]
>    worker_thread+0x770/0x10b0 kernel/workqueue.c:3400
>    kthread+0x465/0x880 kernel/kthread.c:464
>    ret_from_fork+0x4d/0x80 arch/x86/kernel/process.c:153
>    ret_from_fork_asm+0x19/0x30 arch/x86/entry/entry_64.S:245
>    </TASK>
> 
> [...]

Here is the summary with links:
  - [bpf,v4] bpf: Fix RCU stall in bpf_fd_array_map_clear()
    https://git.kernel.org/bpf/bpf-next/c/4406942e65ca

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      reply	other threads:[~2026-04-10 19:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07 10:38 [PATCH bpf v4] bpf: Fix RCU stall in bpf_fd_array_map_clear() Sechang Lim
2026-04-10 19:20 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177584880680.2610429.13126828004209763320.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=leon.hwang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=rhkrqnwk98@gmail.com \
    --cc=sdf@fomichev.me \
    --cc=song@kernel.org \
    --cc=sun.jian.kdev@gmail.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox