Re: [PATCH net-next v2 1/5] tools: ynl: move ethtool.py to selftest

Stanislav Fomichev
2026-04-08T16:42:35Z

On 04/08, Hangbin Liu wrote:
> We have converted all the samples to selftests. This script is
> the last piece of random "PoC" code we still have lying around.
> Let's move it to tests.
>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> tools/net/ynl/tests/Makefile | 5 ++++-
> tools/net/ynl/{pyynl => tests}/ethtool.py | 2 +-
> tools/net/ynl/tests/test_ynl_ethtool.sh | 2 +-
> 3 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/tools/net/ynl/tests/Makefile b/tools/net/ynl/tests/Makefile
> index 2a02958c7039..94bf0346b54d 100644
> --- a/tools/net/ynl/tests/Makefile
> +++ b/tools/net/ynl/tests/Makefile
> @@ -36,7 +36,10 @@ TEST_GEN_FILES := \
> rt-route \
> # end of TEST_GEN_FILES
>
> -TEST_FILES := ynl_nsim_lib.sh
> +TEST_FILES := \
> + ethtool.py \
> + ynl_nsim_lib.sh \
> +# end of TEST_FILES
>
> CFLAGS_netdev:=$(CFLAGS_netdev) $(CFLAGS_rt-link)
> CFLAGS_ovs:=$(CFLAGS_ovs_datapath)
> diff --git a/tools/net/ynl/pyynl/ethtool.py b/tools/net/ynl/tests/ethtool.py
> similarity index 99%
> rename from tools/net/ynl/pyynl/ethtool.py
> rename to tools/net/ynl/tests/ethtool.py
> index f1a2a2a89985..6eeeb867edcf 100755
> --- a/tools/net/ynl/pyynl/ethtool.py
> +++ b/tools/net/ynl/tests/ethtool.py
> @@ -14,7 +14,7 @@ import re
> import os
>
> # pylint: disable=no-name-in-module,wrong-import-position
> -sys.path.append(pathlib.Path(__file__).resolve().parent.as_posix())
> +sys.path.append(pathlib.Path(__file__).resolve().parent.parent.joinpath('pyynl').as_posix())
> # pylint: disable=import-error
> from cli import schema_dir, spec_dir
> from lib import YnlFamily
> diff --git a/tools/net/ynl/tests/test_ynl_ethtool.sh b/tools/net/ynl/tests/test_ynl_ethtool.sh
> index b826269017f4..b4480e9be7b7 100755
> --- a/tools/net/ynl/tests/test_ynl_ethtool.sh
> +++ b/tools/net/ynl/tests/test_ynl_ethtool.sh
> @@ -8,7 +8,7 @@ KSELFTEST_KTAP_HELPERS="$(dirname "$(realpath "$0")")/../../../testing/selftests
> source "$KSELFTEST_KTAP_HELPERS"
>
> # Default ynl-ethtool path for direct execution, can be overridden by make install
> -ynl_ethtool="../pyynl/ethtool.py"
> +ynl_ethtool="./ethtool.py"
>
> readonly NSIM_ID="1337"
> readonly NSIM_DEV_NAME="nsim${NSIM_ID}"

Do we need to add some expects/asserts to the script to really make it into
a test? Right now it just prints things, so it's not really a test.