From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Hans de Goede <hdegoede@redhat.com>, linux-hwmon@vger.kernel.org
Cc: "Günter Röck" <linux@roeck-us.net>,
"Jean Delvare" <jdelvare@suse.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: hwmon/sch5627: Use common error handling code in sch5627_probe()
Date: Tue, 13 Mar 2018 09:25:51 +0100 [thread overview]
Message-ID: <17810b74-7b72-074e-5fef-b614fcfed738@users.sourceforge.net> (raw)
In-Reply-To: <0cc0ab31-550b-fa34-aaa5-164f6ae7f7a9@redhat.com>
>> Adjust jump targets so that a bit of exception handling can be better
>> reused at the end of this function.
…
> goto-s going to a label calling another goto is completely unreadable.
I got an other software development view.
> I really do not see any reason for the proposed changes,
I suggest to look once more.
> they may remove a small amount of code duplication,
This was my software design goal in this case.
> but at a hugh cost wrt readability.
I proposed a different trade-off here.
Regards,
Markus
next prev parent reply other threads:[~2018-03-13 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 21:23 [PATCH] hwmon/sch5627: Use common error handling code in sch5627_probe() SF Markus Elfring
2018-03-13 8:19 ` Hans de Goede
2018-03-13 8:25 ` SF Markus Elfring [this message]
2018-03-13 8:52 ` Hans de Goede
2018-03-13 9:30 ` SF Markus Elfring
2018-03-13 16:00 ` [PATCH] " Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17810b74-7b72-074e-5fef-b614fcfed738@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).