From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B76C46471 for ; Mon, 6 Aug 2018 10:30:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60D0521A03 for ; Mon, 6 Aug 2018 10:30:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60D0521A03 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729776AbeHFMiy (ORCPT ); Mon, 6 Aug 2018 08:38:54 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:52441 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727517AbeHFMiy (ORCPT ); Mon, 6 Aug 2018 08:38:54 -0400 Received: from 79.184.254.16.ipv4.supernova.orange.pl (79.184.254.16) (HELO aspire.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83) id 54a2155ba66b4be0; Mon, 6 Aug 2018 12:30:27 +0200 From: "Rafael J. Wysocki" To: Kees Cook Cc: "Rafael J. Wysocki" , Herbert Xu , Arnd Bergmann , Eric Biggers , "Gustavo A. R. Silva" , Alasdair Kergon , Rabin Vincent , Tim Chen , Pavel Machek , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , Philipp Reisner , Lars Ellenberg , Jens Axboe , Giovanni Cabiddu , Mike Snitzer , Paul Mackerras , Greg Kroah-Hartman , David Howells , Johannes Berg , Tudor-Dan Ambarus , Jia-Ju Bai , Andrew Morton , Geert Uytterhoeven , Josh Poimboeuf , David Woodhouse , Will Deacon , device-mapper development , Linux PM , linux-crypto , drbd-dev@lists.linbit.com, linux-block , qat-linux@intel.com, linux-ppp@vger.kernel.org, netdev , "open list:ANDROID DRIVERS" , linux-afs@lists.infradead.org, "open list:NETWORKING DRIVERS (WIRELESS)" , Linux Kernel Mailing List Subject: Re: [PATCH v6 10/18] x86/power/64: Remove VLA usage Date: Mon, 06 Aug 2018 12:28:28 +0200 Message-ID: <1782361.6NaZWiq7ky@aspire.rjw.lan> In-Reply-To: References: <20180724164936.37477-1-keescook@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, July 25, 2018 8:01:47 PM CEST Kees Cook wrote: > On Wed, Jul 25, 2018 at 4:32 AM, Rafael J. Wysocki wrote: > > On Tue, Jul 24, 2018 at 6:49 PM, Kees Cook wrote: > >> In the quest to remove all stack VLA usage from the kernel[1], this > >> removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to > >> shash directly and allocating the descriptor in heap memory (which should > >> be fine: the tfm has already been allocated there too). > >> > >> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com > >> > >> Signed-off-by: Kees Cook > >> Acked-by: Pavel Machek > > > > I think I can queue this up if there are no objections from others. > > > > Do you want me to do that? > > Sure thing. It looks like the other stand-alone patches like this one > are getting taken into the non-crypto trees, so that's fine. > Applied now, thanks!