Re: [PATCH 0/4] devfreq: exynos4: Support dt and use common ppmu driver

Bartlomiej Zolnierkiewicz
2014-03-12T15:36:31Z

Hi,

On Wednesday, March 12, 2014 08:47:58 PM Chanwoo Choi wrote:
> This patchset support devicetree and use common ppmu driver instead of
> individual code of exynos4_bus.c to remove duplicate code. Also this patchset
> get the resources for busfreq from dt data by using DT helper function.
> - PPMU register address
> - PPMU clock
> - Regulator for INT/MIF block
>
> This patchset use SET_SYSTEM_SLEEP_PM_OPS macro intead of legacy method.
> To remove power-leakage in suspend state, before entering suspend state,
> disable ppmu clocks.
>
> Chanwoo Choi (4):
> devfreq: exynos4: Support devicetree to get device id of Exynos4 SoC
> devfreq: exynos4: Use common ppmu driver and get ppmu address from dt data
> devfreq: exynos4: Add ppmu's clock control and code clean about regulator control
> devfreq: exynos4: Use SET_SYSTEM_SLEEP_PM_OPS macro instead of legacy method
>
> drivers/devfreq/exynos/exynos4_bus.c | 396 ++++++++++++++++++++++++-----------
> 1 file changed, 271 insertions(+), 125 deletions(-)

The patchset generally looks OK, for my review comments please see separate
mails. One thing I forgot to mention yet: please also fix DTS files so
exynos4_bus driver is finally functional (currently even with this patchset
it is not).

PS Please also add linux-samsung-soc@vger.kernel.org to Cc: when sending
the next revision of this patchset.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics