From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29CEB390C8E for ; Wed, 8 Jul 2026 23:34:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783553662; cv=none; b=bg/fu2vUZESfyshbOFzcc1b0veVZTnhdZ21kTi0hVb/KX4ZtpFR+1AV6veo1Qe9s/I8zWUCniyH83VYd+ZJvcfGFdocyR/vMdyHnmwmjNwyyly8Bty88mdhqaE7THCd+K46fHZmmNqKbGuoG+dRtYOcP2kT+I2z+xxm76vqvSGA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783553662; c=relaxed/simple; bh=SEEDZkOUfd25t3/q5fUjUFSgpg1480t5VP3MGXxMgiM=; h=From:To:Cc:Subject:Date:Message-ID:Content-Type:MIME-Version: In-Reply-To:References; b=i/DJON5SjZBQN/00SIlXbk3fm8ihP/5DYvjrYWMm1pBYFWlJMGEzGQqdqHbwNslciLUSXHCr+4kM7OxigZlBMOckPIHVb0Ax512NH0xUB/sgKk05nEt3ySrWexZys8v+T4X31oODGpx+E2JDpbh7qoYEH2rE06wQjrJ2XXx1+g8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fMRK5P8x; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fMRK5P8x" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2cac59f8b64so14777355ad.0 for ; Wed, 08 Jul 2026 16:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783553660; x=1784158460; darn=vger.kernel.org; h=references:in-reply-to:mime-version:content-type:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pBxe0wZEJGIu1kkVYecVy6uNbnIpdD9XRHlLQPSVa+E=; b=fMRK5P8xqWkcIGx2pUUwEt0dN666xAzxXzRvt28MykgHBHLG3XFqBDToVwbsZVXdop T6mre5X+5OBLuSfd/OaieU/1y76nbUyq18x8JnPfM0BCv2/kgS3iyBMZoHKyRav/VLSq mAZkrskCUeN4/coGB+nHkvlw6OyS96ySRF8ZBWyaHMmpwPKEzxz6QtCtj2r2ouEC4KVY vgqPhjUkYPOICLeWUZiIaglcNevuuQam7eI4VVHSsCCGQ1AQw6Pg6UJ+iVWDMbAm+PJz uJ0dBImc8uLxCql4ynOzTfhpn2WkxZCL/In0rhJoUdEIgIZh1Z6hsbXFhealBWzBQ4kq qKcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783553660; x=1784158460; h=references:in-reply-to:mime-version:content-type:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=pBxe0wZEJGIu1kkVYecVy6uNbnIpdD9XRHlLQPSVa+E=; b=ryQFvmMzk6ce00MstCHIehWmgvcIz2cVmjPJt3HZiaSklMpAH1EoBUcTdB3mm3vJrj PZ/H8OJekdM463jbR9kDF0KYc5D9vGalRlo9bVoG2rbIwVOLnjz0hhhmDxrGXDIZgpHA DvUYZcgRGW6lbah64FhYa8buE2WrEL7PQbvP8TnZ2o65B3GESViBNQrGC8H8L1tSINe5 j6niFSnCt0xG+Z+MfOxjjkb7HxuSLlrveG6MW7Aifc9FcMYxB91Q5xOq4vPwKHG9Pw4P SjnQNMsJflpIhQXIjTYki9qcE/8kjkstUmsr9Na9nV8ez8YvPfSCvmdy7KYRhwktGfZr QhVQ== X-Forwarded-Encrypted: i=1; AHgh+RqvGC7rcZFsyzkzQP/6BYIV24oSao9H6yE3g4rH4C0nksPYmQVgByYty2sAAtQT/GtvybHnEwQOf+ucNw4=@vger.kernel.org X-Gm-Message-State: AOJu0YzyaCBfEiq+kGeOkXuvrtmJOoFHwluNAY0O0YmzVTStHMqj7jYd zDygX0jERh6EGc7vGKy5d7CAINs9wG/gajyNUtQ9q5+gkSbBHs6qVgoQ X-Gm-Gg: AfdE7cn+ibg8OiXFFEtdbHwtpaUYsqqC6Mw87/lyQaBq7FuzOKX5vee8JOjB01TD2V1 /kpeLRI7GJ6RrYEdghvaeIRG5MaWS+xpeyL/Dn57tfqz66g6PmYI4fOCIRj980Mi3OVKwuchcQY Q5bwvQYHXHUJTR+9Wl7oQbvKt18lNRuN1JlV38cKcDkIfvgUnif4rUudyrmdKB/JFOrdpmIoReU R9pIttyXV2Q1kDtqwydB4a8fL5JtCAiZ10griC9EK0amZealHyj3dfxlbyeYep5kzmvFDCAinqT 9uY8Ca7ciMkx6Dm4IWAr9rimCunIxqoDPF5921Q47H9vihZqSCPgqExHIlkn3xqTZ1O/LDPDkqH /hef7KNdQTGhtUcg1G5zjWZAgrDoOxWMBce3I0BSjHvRMPaNGJi2Jbr660tPHW6JVJzJtr27ONy Eg7nK/Ww== X-Received: by 2002:a17:902:fc84:b0:2c9:df1b:e948 with SMTP id d9443c01a7336-2ccea2d7691mr53663815ad.4.1783553660562; Wed, 08 Jul 2026 16:34:20 -0700 (PDT) Received: from [127.0.1.1] ([47.253.114.73]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d1edb0sm33898515ad.53.2026.07.08.16.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 16:34:20 -0700 (PDT) From: Wayen Yan To: netdev@vger.kernel.org Cc: lorenzo@kernel.org, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, andrew+netdev@lunn.ch, angelogioacchino.delregno@collabora.com, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Daniel Golle , Qingfang Deng , SkyLake Huang , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 5/5] net: phy: mediatek: add calibration logic for AN7583 Date: Thu, 09 Jul 2026 00:31:00 +0800 Message-ID: <178355365385.113886.4040120167909619643@gmail.com> Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20260708102341.53919-6-ansuelsmth@gmail.com> References: <20260708102341.53919-1-ansuelsmth@gmail.com> <20260708102341.53919-6-ansuelsmth@gmail.com> Hi Christian, A few issues in an7583_phy_config_init(): 1) Redundant double assignment of mdi_resister_type shared->mdi_resister_type = MDI_5R; shared->mdi_resister_type = MDI_5R; /* duplicate */ if (shared->mdi_resister_type == MDI_0R) shared->r50_cal_tbl = an7583_zcal_to_r50ohm_0R; if (shared->mdi_resister_type == MDI_5R) shared->r50_cal_tbl = an7583_zcal_to_r50ohm_5R; The first assignment is immediately overwritten by the second identical one. Also the two `if` blocks should be `else if` -- currently both conditions are checked independently and the MDI_0R branch is dead code (since the value is hardcoded to MDI_5R). If the intent is to default to MDI_5R and later read from SoC, the structure should be: shared->mdi_resister_type = MDI_5R; /* FIXME: read from SCU */ if (shared->mdi_resister_type == MDI_0R) shared->r50_cal_tbl = an7583_zcal_to_r50ohm_0R; else shared->r50_cal_tbl = an7583_zcal_to_r50ohm_5R; 2) Typo: mdi_resister_type -> mdi_resistor_type (same as patch 4/5) Also the FIXME comment says "MDI Resister Type" -- should be "Resistor Type". 3) Dependency on patch 4/5 probe fix an7583_phy_config_init() uses shared->phydev_p0 which is set in an7581_phy_probe(). If the probe function from patch 4/5 is not fixed (missing shared = phy_package_get_priv(phydev)), this will deref NULL/garbage: phydev_p0 = shared->phydev_p0; phy_offset = phydev->mdio.addr - phydev_p0->mdio.addr; This highlights that patch 4/5's probe fix is a blocker for both AN7581 and AN7583. Best, Wayen