Re: [PATCH v1] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)

Bruno Thomsen
2023-11-08T22:51:31Z

Den fre. 3. nov. 2023 kl. 22.07 skrev Fabio Estevam <festevam@gmail.com>:
>
> [Adding Bruno and Alexander]
>
> On Thu, Nov 2, 2023 at 7:12 PM João Rodrigues <jrodrigues@ubimet.com> wrote:
> >
> > From: João Rodrigues <jrodrigues@ubimet.com>
> >
> > TQMa7x (revision 01xxx) uses a LM75A temperature sensor.
> > The two sensors use different I2C addresses, so we can set both sensors
> > simultaneously.

Hi João,

Looks correct to me and an elegant way of adding support for rev 01xx boards.

Reviewed-by: Bruno Thomsen <bruno.thomsen@gmail.com>

After this change the imx7d-flex-concentrator.dts needs to be updated
as it uses TQMa7d rev 02xx boards with something like this:

/* TQMa7d 02xx */
&se97b {
status = "okay";
};

I can send a follow up patch when this change lands.

/Bruno

> >
> > Signed-off-by: João Rodrigues <jrodrigues@ubimet.com>
> > ---
> > arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > index fe42b0a4683..3fc3130f9de 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> > @@ -128,11 +128,16 @@ vgen6_reg: vldo4 {
> > };
> > };
> >
> > - /* NXP SE97BTP with temperature sensor + eeprom */
> > + /* LM75A temperature sensor, TQMa7x 01xx */
> > + lm75a: temperature-sensor@48 {
> > + compatible = "national,lm75a";
> > + reg = <0x48>;
> > + };
> > +
> > + /* NXP SE97BTP with temperature sensor + eeprom, TQMa7x 02xx */
> > se97b: temperature-sensor-eeprom@1e {
> > compatible = "nxp,se97b", "jedec,jc-42.4-temp";
> > reg = <0x1e>;
> > - status = "okay";
> > };
> >
> > /* ST M24C64 */
> > --
> > 2.25.1
> >