From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Shuah Khan <shuah@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: [PATCH v3 0/5] tracing/probes: Clean up and refactor argument parser
Date: Tue, 14 Jul 2026 10:09:26 +0900 [thread overview]
Message-ID: <178399136606.27810.4469135881050354189.stgit@devnote2> (raw)
Hi,
This is the 3rd version of the series which refactors and cleans up
the fetcharg parser in the trace_probe. The previous version is here:
https://lore.kernel.org/all/178392766002.3229912.15711868107734330750.stgit@devnote2/
The main goals are to improve code readability, prevent kernel stack
overflow by eliminating recursive function calls, and extend the
argument string length limit to support complex BTF typecast
expressions.
In this version, I fixed to remove unused variable and add a
error log in parse_this_cpu() [5/5].
Patches:
- Patch 1: Decomposes parse_probe_vars() into smaller, dedicated helper
functions for parsing specific variable types ($retval, $stack, etc.).
- Patch 2: Decomposes parse_probe_arg() into static helper subroutines for
handling registers, memory/symbols, and immediates.
- Patch 3: Alphabetizes the ERRORS macros list in trace_probe.h to improve
readability.
- Patch 4: Extends MAX_ARGSTR_LEN from 63 to 255 for long BTF cast/dereference
arguments, and introduces MAX_COMMON_HEAD_LEN to prevent regression on match
head commands.
- Patch 5: Eliminates recursion in parse_probe_arg() using a loop and a parse
state stack integrated into traceprobe_parse_context. It also raises the
nesting limit to 8 and updates the selftest scripts.
Thanks,
---
Masami Hiramatsu (5):
tracing/probes: Refactor parse_probe_vars()
tracing/probes: Refactor parse_probe_arg()
tracing/probes: Sort ERRORS list in trace_probe.h alphabetically
tracing/probes: Extend max length of argument string
tracing/probes: Eliminate recursion in parse_probe_arg()
kernel/trace/trace_fprobe.c | 2
kernel/trace/trace_kprobe.c | 2
kernel/trace/trace_probe.c | 833 ++++++++++++--------
kernel/trace/trace_probe.h | 196 +++--
kernel/trace/trace_uprobe.c | 2
.../ftrace/test.d/dynevent/fprobe_syntax_errors.tc | 6
.../ftrace/test.d/dynevent/tprobe_syntax_errors.tc | 4
.../ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 6
8 files changed, 623 insertions(+), 428 deletions(-)
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next reply other threads:[~2026-07-14 1:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 1:09 Masami Hiramatsu (Google) [this message]
2026-07-14 1:09 ` [PATCH v3 1/5] tracing/probes: Refactor parse_probe_vars() Masami Hiramatsu (Google)
2026-07-14 1:09 ` [PATCH v3 2/5] tracing/probes: Refactor parse_probe_arg() Masami Hiramatsu (Google)
2026-07-14 1:09 ` [PATCH v3 3/5] tracing/probes: Sort ERRORS list in trace_probe.h alphabetically Masami Hiramatsu (Google)
2026-07-14 1:10 ` [PATCH v3 4/5] tracing/probes: Extend max length of argument string Masami Hiramatsu (Google)
2026-07-14 1:10 ` [PATCH v3 5/5] tracing/probes: Eliminate recursion in parse_probe_arg() Masami Hiramatsu (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178399136606.27810.4469135881050354189.stgit@devnote2 \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox