From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933966AbcIFJWw (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Sep 2016 05:22:52 -0400
Received: from mout.kundenserver.de ([212.227.17.13]:56191 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933818AbcIFJVV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Sep 2016 05:21:21 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: p.zabel@pengutronix.de, mchehab@kernel.org,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        xie.baoyou@zte.com.cn
Subject: Re: [PATCH] [media] coda: add missing header dependencies
Date: Tue, 06 Sep 2016 11:21:38 +0200
Message-ID: <17845866.BEgCsGq73Z@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1473148256-25347-1-git-send-email-baoyou.xie@linaro.org>
References: <1473148256-25347-1-git-send-email-baoyou.xie@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:VM5qqGWQ3UjobZXOT/sOqb9EHERKjlKvB5xviCE9m89rJ42mW+g
 vjdZ4HxSmz24IjsTcyOSjUulEDw5X+3LU4XykGPMtRstQpp3srKu+fYekaK083OdW8xv6th
 Cr1MD7q5iYZhNfqB2fn1ZxUUuCtgBLLeihy0V3+4XJtVMrXVi2a4mTkTOXZqPaTmbRqM4C3
 2kDnr6DWZhJFWsNMI8HFQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:rccBP7sJVWw=:OqjQ6xHS2lV9uxFgJF6g+d
 yPTtSpFmB+mtwgGxz15t+Ipr0F1ljqgyYzl/Lnro9hj+/uO7hr/IRGcu/Q+lby1JuoldvOSyE
 llqmPWuJEfhp5KBkm83IpTnMj/5mI8dw9HaFQa6R1KFDTtEfyPBUrM2DsPE2oy+oaWDkV6hv/
 wTpYI4WPxwPtaxmTPdzAfj7ibgL0R4O93hSe6YRteRpPFIJFR8MngHTCI14s+q59Fctvqo8kQ
 L5Eo3dgvqHDMY76wpXC8lytf90EX2EbXH5aDa71MgCQ0SZzHZ8tZ5lFBrfDrXGCnPUr/XNK4X
 2xer1NBctJxlq4zk/fWBr5uqUZy9Dylpum2KDrSocxYcMxFucDQEI6HZnVAeztt17Xn04yBZa
 Kc0krU1rI80btCNJEePrwKD2cMLRetrTQsJJEjOQVFiqI3IDbYmanwBBZ1vqRAWP9/GQr61vC
 aELXckBEg1bdKE1bEoyxEE4Ds7aby+zk/jxtmEXv+a4jip24UStKs902bARe05LXdTawAdzFq
 zgmZ09uc5rhx6AbFmvdR29/hoUOcT/Ykd26PKk1n6aRlwoRoHKIAo2ekfUsj1bvyc/tT/g7uu
 7pACV6mfXuL7Vnu8VbU/nXafsdxjOd2do9rwSyWcldA6onq02mra+BI1HuNec1S2etPME+H0E
 s5iooCflNfx2NFobF2nkXJg1ZwNHMdJr9E7b0EN2ndzly9CHysRb+iaJ7JCN276Y7HQ99msc2
 a4HwPhJf7cQU2mlX
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, September 6, 2016 3:50:56 PM CEST Baoyou Xie wrote:
>  #include <linux/kernel.h>
>  #include <linux/string.h>
> +#include <coda.h>
> 

by convention, we tend to write this as

#include "coda.h"

otherwise the patch looks good to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>