From: Ihor Solodrai <ihor.solodrai@linux.dev>
To: Martin KaFai Lau <martin.lau@linux.dev>, xulang <xulang@uniontech.com>
Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
daniel@iogearbox.net, dzm91@hust.edu.cn, eddyz87@gmail.com,
haoluo@google.com, huyinhao@hust.edu.cn,
john.fastabend@gmail.com, jolsa@kernel.org, kaiyanm@hust.edu.cn,
kernel@uniontech.com, kpsingh@kernel.org,
linux-kernel@vger.kernel.org, paul.chaignon@gmail.com,
sdf@fomichev.me, song@kernel.org, yonghong.song@linux.dev
Subject: Re: [PATCH bpf v1] bpf: Fix OOB in bpf_obj_memcpy for cgroup storage
Date: Mon, 16 Mar 2026 14:22:50 -0700 [thread overview]
Message-ID: <1784ff89-96de-4b75-89c7-94c914326b93@linux.dev> (raw)
In-Reply-To: <82ee475b-034a-442c-b290-cc7905a7f33c@linux.dev>
On 3/16/26 1:50 PM, Martin KaFai Lau wrote:
>
>
> On 3/16/26 6:51 AM, xulang wrote:
>> From: Lang Xu <xulang@uniontech.com>
>>
>>> Please create a selftest for this.
>>
>> Going to do that. To stably reproduce this bug, I need the KASAN
>> config enabled, how do I ensure it's enabled during a selftest cycle,
>> by adding the line below to the 'config'? not quite sure.
>>
>> --- a/tools/testing/selftests/bpf/config
>> +++ b/tools/testing/selftests/bpf/config
>> @@ -46,6 +46,7 @@ CONFIG_IPV6_GRE=y
>> CONFIG_IPV6_SEG6_BPF=y
>> CONFIG_IPV6_SIT=y
>> CONFIG_IPV6_TUNNEL=y
>> +CONFIG_KASAN=y
>
> I would leave out this config change from this fix for now. cc: Ihor to consider enabling it for bpf-next.
>
> It is still useful to have a selftest for this case. I always have KASAN turned on when running selftests.
Hi Martin. BPF CI has been running with KASAN since July 2025.
We only disabled it on s390x due to frequent OOMs, x86_64 and
aarch64 are covered.
For BPF CI it's not important whether CONFIG_KASAN=y is enabled
in tools/testing/selftests/bpf/config, as long as it's not =n
>
>
>>> [...]
next prev parent reply other threads:[~2026-03-16 21:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 5:25 [PATCH bpf v1] bpf: Fix OOB in bpf_obj_memcpy for cgroup storage xulang
2026-03-12 11:51 ` Paul Chaignon
2026-03-12 16:41 ` Yonghong Song
2026-03-12 18:02 ` Paul Chaignon
2026-03-12 19:58 ` Yonghong Song
2026-03-12 16:46 ` Yonghong Song
2026-03-13 20:34 ` Martin KaFai Lau
2026-03-16 13:51 ` xulang
2026-03-16 20:50 ` Martin KaFai Lau
2026-03-16 21:22 ` Ihor Solodrai [this message]
2026-03-17 10:02 ` [PATCH bpf 0/2] bpf: Fix and test cgroup storage OOB issue xulang
[not found] ` <20260317100227.2157104-1-xulang@uniontech.com>
2026-03-17 10:02 ` [PATCH bpf 1/2] bpf: Fix OOB in bpf_obj_memcpy for cgroup storage xulang
2026-03-25 1:36 ` Martin KaFai Lau
2026-03-17 10:02 ` [PATCH bpf 2/2] selftests/bpf: Add test for cgroup storage OOB read xulang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1784ff89-96de-4b75-89c7-94c914326b93@linux.dev \
--to=ihor.solodrai@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dzm91@hust.edu.cn \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=huyinhao@hust.edu.cn \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kaiyanm@hust.edu.cn \
--cc=kernel@uniontech.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=paul.chaignon@gmail.com \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=xulang@uniontech.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox