From: patchwork-bot+f2fs@kernel.org
To: Zhan Xusheng <zhanxusheng1024@gmail.com>
Cc: jaegeuk@kernel.org, chao@kernel.org, brauner@kernel.org,
zhanxusheng@xiaomi.com, jack@suse.cz,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, pfalcato@suse.de
Subject: Re: [f2fs-dev] [PATCH] f2fs: use the mount idmap for the owner check in f2fs_xattr_advise_set()
Date: Wed, 05 Aug 2026 21:20:40 +0000 [thread overview]
Message-ID: <178596484038.530543.7575324835869629902.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260716025908.608098-1-zhanxusheng@xiaomi.com>
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <jaegeuk@kernel.org>:
On Thu, 16 Jul 2026 10:59:08 +0800 you wrote:
> f2fs_xattr_advise_set() calls inode_owner_or_capable() with &nop_mnt_idmap
> before allowing the "system.advise" xattr to be set, instead of the idmap
> that the VFS passes to the ->set() handler.
>
> f2fs supports idmapped mounts, so on such a mount this checks the caller's
> fsuid against the unmapped on-disk owner rather than the mapped owner: the
> actual owner can be wrongly denied with -EPERM and an unrelated caller
> wrongly allowed. Pass the handler's idmap instead.
>
> [...]
Here is the summary with links:
- [f2fs-dev] f2fs: use the mount idmap for the owner check in f2fs_xattr_advise_set()
https://git.kernel.org/jaegeuk/f2fs/c/a54ffce4637a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2026-08-05 21:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 2:59 [PATCH] f2fs: use the mount idmap for the owner check in f2fs_xattr_advise_set() Zhan Xusheng
2026-08-03 6:34 ` Chao Yu
2026-08-05 21:20 ` patchwork-bot+f2fs [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-07-29 4:16 Rochan Avlur
2026-07-30 10:23 ` Christian Brauner
2026-08-03 23:33 ` [f2fs-dev] " Jaegeuk Kim
2026-08-05 21:20 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178596484038.530543.7575324835869629902.git-patchwork-notify@kernel.org \
--to=patchwork-bot+f2fs@kernel.org \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pfalcato@suse.de \
--cc=stable@vger.kernel.org \
--cc=zhanxusheng1024@gmail.com \
--cc=zhanxusheng@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox