From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFB6C3955E3; Sat, 22 Aug 2026 09:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787390713; cv=none; b=NPtQ99lJoIxhGvxeUsKMOzKmfibdPeWXtRt8fHm+1ncOD8XiYFQX2zJ2+WJVc3lDbaL6mlkeHNjJ8HCsrl8NBRZgOwSuMSKmzY+mRQfKaocZYWDLevwCyPEDpYGFPpldM9E745SOyjJzdi/hycOgNjxtYTrRDP65Pr3RZUwqCio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787390713; c=relaxed/simple; bh=VqLlDHSMm+MF/WnRQsL57yZNI/cI4dWh3JkHaugvCnU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DHaOSvwoS9lvSNiy9YD5Xjx1e6/bssuK9fSu0nd3Ltg14xJu+U6N1KLQN7+wHw1w852Uy3ULCsElXjM4FlLzmsNcM55w3F9eLxh6d4cijyDcNoalj+c2FXXDLZ6kCf7B+gx7/mt6R9ruqJvTOMgo6RK6FqU63YiFLnKHdpfAm84= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jcTttmaw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jcTttmaw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A9B81F000E9; Sat, 22 Aug 2026 09:25:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787390710; bh=+wgh4xL7ZNeBpG1JUywSETJX4mapAzlpKlc/VwEKCWI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jcTttmawXZQ+Jih1VHsd/HRWiuhLDm7PKHUvCNAg0iW6sUp9CMKInZaLLhNJ1Bkki hiiKZn+tmL3pcf+0viism8ZkySl8Z/pSqNjh9evUv+2g8Razo6LYlUkMhcSw6QP7GJ 3QPXsdUF/CkxAjxMJ0V2vHvP2s3Kbk2psr8S3JVfF/r3A/KgSfz/gyoJZ3wzk6ODV+ X9vnnz9mc3vYvEc5sYNkC9iKA1Pn00JogyNAI5nmY+jbQ1z8cAS+0f/W0Eb2j7taid BkQYS0pjznJ5SJL/qPG1CHGqhNhGp2MUCprDGV2Tr+EnsLjyrvzQwQXPHO2xVoRAXZ uCcLEXM6aAg2g== From: "Masami Hiramatsu (Google)" To: Steven Rostedt , Peter Zijlstra , Ingo Molnar , x86@kernel.org Cc: Jinchao Wang , Mathieu Desnoyers , Masami Hiramatsu , Thomas Gleixner , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Alexander Shishkin , Ian Rogers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: [PATCH v13 10/12] selftests: ftrace: Add wprobe trigger testcase Date: Sat, 22 Aug 2026 18:25:04 +0900 Message-ID: <178739070441.1520941.13438898193952389821.stgit@devnote2> X-Mailer: git-send-email 2.43.0 In-Reply-To: <178739053919.1520941.17662338993878200834.stgit@devnote2> References: <178739053919.1520941.17662338993878200834.stgit@devnote2> User-Agent: StGit/0.19 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit From: Masami Hiramatsu (Google) Add a testcase for checking wprobe trigger. This sets set_wprobe and clear_wprobe triggers on fprobe event and static trace event to monitor memory accesses within the trace-events-sample kernel module. Also add a testcase for verifying wprobe trigger syntax error logging. Link: https://lore.kernel.org/all/59637b96946653393a7ad3c7de094094796b39c2.1785067572.git.wangjinchao600@gmail.com/ Signed-off-by: Masami Hiramatsu (Google) --- Changes in v13: - Look up target function dynamically in trigger-wprobe-syntax-errors.tc. - Disable set_wprobe trigger before verifying clear_wprobe in trigger-wprobe.tc to avoid race condition with sample_timer_cb. Changes in v12: - Add trigger-wprobe-syntax-errors.tc for verifying wprobe trigger syntax error logging. - Fix requires line in trigger-wprobe-syntax-errors.tc so test is not evaluated as unsupported prior to execution. - Define dfd=$arg1 fetcharg on testevent for trigger syntax checks. Changes in v11: - Update testcase to use trace-events-sample kernel module instead of VFS file operations. --- tools/testing/selftests/ftrace/config | 1 .../test.d/trigger/trigger-wprobe-syntax-errors.tc | 37 +++++++++ .../ftrace/test.d/trigger/trigger-wprobe.tc | 87 ++++++++++++++++++++ 3 files changed, 125 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-wprobe-syntax-errors.tc create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-wprobe.tc diff --git a/tools/testing/selftests/ftrace/config b/tools/testing/selftests/ftrace/config index d2f503722020..ecdee77f360f 100644 --- a/tools/testing/selftests/ftrace/config +++ b/tools/testing/selftests/ftrace/config @@ -28,3 +28,4 @@ CONFIG_TRACER_SNAPSHOT=y CONFIG_UPROBES=y CONFIG_UPROBE_EVENTS=y CONFIG_WPROBE_EVENTS=y +CONFIG_WPROBE_TRIGGERS=y diff --git a/tools/testing/selftests/ftrace/test.d/trigger/trigger-wprobe-syntax-errors.tc b/tools/testing/selftests/ftrace/test.d/trigger/trigger-wprobe-syntax-errors.tc new file mode 100644 index 000000000000..8ddef1dcd678 --- /dev/null +++ b/tools/testing/selftests/ftrace/test.d/trigger/trigger-wprobe-syntax-errors.tc @@ -0,0 +1,37 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: event trigger - test wprobe trigger syntax errors +# requires: dynamic_events error_log "w[:[/][]] [r|w|rw]@[:]":README "f[:[/][]] [%return] []":README + +check_error() { # command-with-error-pos-by-^ + ftrace_errlog_check "wprobe_trigger" "$1" "events/fprobes/testevent/trigger" +} + +TARGET_FUNC=$(grep -m 1 -E -w "[tT] (vfs_read|do_sys_openat2|do_sys_open)" /proc/kallsyms | awk '{print $3}') +if [ -z "$TARGET_FUNC" ]; then + echo "UNRESOLVED: target function not found" + exit_unresolved +fi + +# Add a dummy fprobe event to attach triggers to +echo "f:fprobes/testevent $TARGET_FUNC dfd=\$arg1" > dynamic_events + +# Add a target wprobe event +echo 'w:watch rw@0:8' >> dynamic_events + +# Test errors on trigger syntax +check_error 'set_wprobe:^non_exist_wprobe:dfd' # WPROBE_NOT_FOUND +check_error 'set_wprobe:^' # WPROBE_NOT_FOUND +check_error 'set_wprobe:watch^' # WPROBE_NEED_FIELD +check_error 'set_wprobe:watch:^non_exist_field' # NO_EVENT_FIELD + +# Enable target wprobe event and test WPROBE_BUSY error +echo 1 > events/wprobes/watch/enable +check_error 'set_wprobe:^watch:dfd' # WPROBE_BUSY +echo 0 > events/wprobes/watch/enable + +# Cleanup +echo '-:watch' >> dynamic_events +echo '-:testevent' >> dynamic_events + +exit 0 diff --git a/tools/testing/selftests/ftrace/test.d/trigger/trigger-wprobe.tc b/tools/testing/selftests/ftrace/test.d/trigger/trigger-wprobe.tc new file mode 100644 index 000000000000..0565e2c42177 --- /dev/null +++ b/tools/testing/selftests/ftrace/test.d/trigger/trigger-wprobe.tc @@ -0,0 +1,87 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: event trigger - test wprobe trigger +# requires: dynamic_events "w[:[/][]] [r|w|rw]@[:]":README events/sched/sched_process_fork/trigger + +rmmod trace-events-sample ||: +if ! modprobe trace-events-sample ; then + echo "No trace-events sample module - please make CONFIG_SAMPLE_TRACE_EVENTS=m" + exit_unresolved +fi + +cleanup_wprobe_triggers() { + if [ -f events/fprobes/testevent/trigger ]; then + reset_trigger_file events/fprobes/testevent/trigger || true + fi + if [ -f events/sample-trace/foo_bar_with_fn/trigger ]; then + reset_trigger_file events/sample-trace/foo_bar_with_fn/trigger || true + fi + echo 0 > events/enable 2>/dev/null || true + echo > dynamic_events 2>/dev/null || true + sleep 1 + rmmod trace-events-sample 2>/dev/null || true + return 0 +} + +trap cleanup_wprobe_triggers EXIT + +echo 0 > tracing_on + +# we will skip this test if fprobe is not supported. +if ! grep -Fq "f[:[/][]] [%return] []" README; then + echo "UNRESOLVED: fprobe is not supported" + exit_unresolved +fi + +# we will skip this test if the target function does not exist. +if ! grep -wq "sample_timer_cb" /proc/kallsyms; then + echo "UNRESOLVED: sample_timer_cb not found" + exit_unresolved +fi + +:;: "Add a wprobe event used by trigger" ;: +echo 'w:watch rw@0:8 address=$addr value=$value' > dynamic_events + +:;: "Add events for triggering wprobe" ;: +echo 'f:fprobes/testevent sample_timer_cb timer=t' >> dynamic_events + +:;: "Enable all events before setting triggers" ;: +echo 1 > tracing_on +echo 1 >> events/fprobes/testevent/enable +echo 1 >> events/sample-trace/foo_bar_with_fn/enable + +:;: "Set set_wprobe trigger on testevent" ;: +echo 'set_wprobe:watch:timer' >> events/fprobes/testevent/trigger +cat events/fprobes/testevent/trigger | grep ^set_wprobe + +# Wait for sample_timer_cb to fire and set_wprobe trigger to activate +sleep 2 + +:;: "Check set_wprobe trigger activated the watchpoint" ;: +cat trace | grep watch + +:;: "Set clear_wprobe trigger on foo_bar_with_fn" ;: +echo 'clear_wprobe:watch' >> events/sample-trace/foo_bar_with_fn/trigger +cat events/sample-trace/foo_bar_with_fn/trigger | grep ^clear_wprobe + +# Disable set_wprobe to prevent sample_timer_cb from re-arming the watchpoint +echo '!set_wprobe:watch:timer' >> events/fprobes/testevent/trigger + +# Clear trace and wait to ensure no new watchpoint events are generated +clear_trace +sleep 1 + +:;: "Ensure clear_wprobe trigger deactivated the watchpoint" ;: +! grep -q watch trace + +:;: "Remove wprobe triggers" ;: +echo '!clear_wprobe:watch' >> events/sample-trace/foo_bar_with_fn/trigger +! grep ^set_wprobe events/fprobes/testevent/trigger +! grep ^clear_wprobe events/sample-trace/foo_bar_with_fn/trigger + +:;: "Disable events and remove dynamic events" ;: +echo 0 > events/enable +echo > dynamic_events +clear_trace + +exit 0