From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752111AbcACBbd (ORCPT ); Sat, 2 Jan 2016 20:31:33 -0500 Received: from mail0131.smtp25.com ([75.126.84.131]:47780 "EHLO mail0131.smtp25.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751528AbcACBb3 (ORCPT ); Sat, 2 Jan 2016 20:31:29 -0500 From: covici@ccs.covici.com To: Samuel Thibault , William Hubbs , Chris Brannon , Kirk Reiser , Greg Kroah-Hartman , speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Mail-Followup-To: Samuel Thibault , William Hubbs , Chris Brannon , Kirk Reiser , Greg Kroah-Hartman , speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: speakup: Fix getting port information In-reply-to: <20160103005620.GM2860@var.home> References: <20160102232529.GC2860@var.home> <15457.1451779836@ccs.covici.com> <20160103005620.GM2860@var.home> Comments: In-reply-to Samuel Thibault message dated "Sun, 03 Jan 2016 01:56:20 +0100." X-Mailer: MH-E 8.5; nmh 1.6; GNU Emacs 23.4.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <17918.1451784671.1@ccs.covici.com> Date: Sat, 02 Jan 2016 20:31:11 -0500 Message-ID: <17919.1451784671@ccs.covici.com> X-SpamH-OriginatingIP: 70.109.53.110 X-SpamH-Filter: d-out-001.smtp25.com-u031VB7W020220 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Well, OK with me, I will use yours instead because I don't know if they will backport the thing, thanks so much for doing this. Samuel Thibault wrote: > covici@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > > I had a patch which also worked, but yours may be better -- I enclose it > > here for your information. > > Well, it's not up to serialio.h to include things for serialio.c. That > however makes me realize that the culprit is actually > f79b0d9 (which actually doesn't make much sense since linux/serial.h is > getting included a couple of lines above...). > > I don't know what this "use instead " > warning is about, but *no* header in include/ includes asm/serial.h, so > there is no way to get the SERIAL_PORT_DFNS definition just by including > linux/serial.h, we really need asm/serial.h, just like 8250*.c do. > > So we really need serialio.c to include linux/serial_core.h then > asm/serial.h, as my patch does. > > Samuel > _______________________________________________ > Speakup mailing list > Speakup@linux-speakup.org > http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup > -- Your life is like a penny. You're going to lose it. The question is: How do you spend it? John Covici covici@ccs.covici.com