public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
	hch@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Making compound pages mandatory
Date: Wed, 17 Nov 2004 12:03:22 +0000	[thread overview]
Message-ID: <17923.1100693002@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0411161912180.2222@ppc970.osdl.org>


> > So I'd suggest that we make compound pages conditional on a new
> > CONFIG_COMPOUND_PAGE and make that equal to HUGETLB_PAGE || !MMU.
> 
> That sounds sane, and seems easily done in init/Kconfig. David?

That looks reasonable, I think.

Would you object to some more micro-optimisations:

 (1) Allow struct page to be marked __attribute__((align(sizeof(long)*2))) on
     archs that want it. On frv for instance this would allow the use of
     double-register load/store instructions when accessing certain adjacent
     pairs of members (such as page->lru.next and page->lru.prev). I think the
     frv compiler will emit these when it knows it won't cause a misalignment
     exception (8-byte accesses must be 8-byte aligned).

 (2) Allow put_page() to be provided by the arch if desired. This would allow
     me to do a better job of testing page flags and mucking around with the
     refcount by writing it in assembly. This is sort of prerequisite on (1)
     and the fact that accesses to page->_count are atomic and so are inline
     asm anyway.

> [ There's too damn many Davids around. DavidH? Mr Howells? Dude? ]

I generally refer to all other Davids as Dave, apart from David Woodhouse who
should be referred to as "Fish":-P

DavidH would be okay.

David

  reply	other threads:[~2004-11-17 12:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-16 18:48 [RFC] Making compound pages mandatory David Howells
2004-11-16 19:20 ` Andrew Morton
2004-11-16 19:41   ` David Howells
2004-11-17  1:50 ` Linus Torvalds
2004-11-17  2:28   ` Andrew Morton
2004-11-17  3:13     ` Nick Piggin
2004-11-17  3:22       ` Nick Piggin
2004-11-17  3:37         ` Nick Piggin
2004-11-17  3:42           ` Nick Piggin
2004-11-17  3:14     ` Linus Torvalds
2004-11-17 12:03       ` David Howells [this message]
2004-11-17 11:47     ` David Howells
2004-11-17 11:43   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17923.1100693002@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox