Re: [PATCH 2/2] x86/microcode: Add microcode loader debugging functionality

[Sohil Mehta <sohil.mehta@intel.com>]

On 8/12/2025 3:26 AM, Borislav Petkov wrote:

>> s/dbg/debug/
>> s/MICROCODE_DBG/MICROCODE_DEBUG
>> s/ucode_dbg/ucode_debug
> 
> No, because I don't want to type unnecessarily and "dbg" is very clear as it
> is.
> 

Yes, in this patch, dbg clearly means debug. But, are some contexts
where dbg is used with other things which might take an extra second to
process. For example,

	if (!cpuid_feature() ||
	    ((native_cpuid_ecx(1) & BIT(31)) && !dbg) ||
	    amd_check_current_patch_level())
		dis_ucode_ldr = true;

In the tradeoff between writing and reading, I am more inclined to make
things easier to read. But obviously your preference supersedes mine :)
> 
>> Should we also include a dependency on DEBUG_KERNEL?
> 
> Because?
> 

To ensure people only use it for debugging purposes similar to
X86_DEBUG_FPU or DEBUG_ENTRY.