From: netdev-bot+sashiko@kernel.org
To: Selvamani.Rajagopal@onsemi.com
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, parthiban.veerasooran@microchip.com,
horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org,
rdunlap@infradead.org, richardcochran@gmail.com, andrew@lunn.ch,
hkallweit1@gmail.com, linux@armlinux.org.uk, edumazet@kernel.org,
piergiorgio.beruto@gmail.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, jerry.ray@microchip.com,
ciprian.regus@analog.com
Subject: Re: [PATCH net-next v11 13/14] net: phy: ncn26000: Support for onsemi's S2500 internal phy
Date: Tue, 17 Nov 2026 19:53:07 +0000 [thread overview]
Message-ID: <179494518788.3136.14432777334635452577@kernel.org> (raw)
In-Reply-To: <20261113-s2500-mac-phy-support-v11-13-7a186141952c@onsemi.com>
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] The new S2500 entry in ncn26000_driver[]
(drivers/net/phy/ncn26000.c) sets `.set_plca_cfg =…
--
net: phy: ncn26000: Support for onsemi's S2500 internal phy
This patch adds a phy_driver entry for the internal PHY of the onsemi
S2500 MAC-PHY to the ncn26000 driver. The NCN26000 TO_TIMER workaround is
skipped on the S2500, and the new entry gets its own config_aneg. It also
adds SQI, OATC14 cable test, loopback and direct C45 MMD access callbacks.
> diff --git a/drivers/net/phy/ncn26000.c b/drivers/net/phy/ncn26000.c
> index 888d74b831256..0e2c978b73d49 100644
> --- a/drivers/net/phy/ncn26000.c
> +++ b/drivers/net/phy/ncn26000.c
[ ... ]
> @@ -162,6 +179,25 @@ static int ncn26000_config_intr(struct phy_device *phydev)
> }
>
> static struct phy_driver ncn26000_driver[] = {
> + {
> + PHY_ID_MATCH_MODEL(PHY_ID_S2500),
> + .name = "S2500",
> + .features = PHY_BASIC_T1S_P2MP_FEATURES,
> + .config_init = ncn26000_config_init,
> + .config_aneg = s2500_config_aneg,
> + .read_status = ncn26000_read_status,
> + .set_loopback = genphy_loopback_no_speed,
> + .set_plca_cfg = ncn26000_c45_plca_set_cfg,
[Severity: Low]
Does bit 7 of VEND2 register 0x8001 also mean Enhanced Noise Immunity on
the S2500?
The S2500 entry reuses ncn26000_c45_plca_set_cfg(). After the generic PLCA
setup, that function also writes the NCN26000-specific ENI bit:
drivers/net/phy/ncn26000.c:ncn26000_c45_plca_set_cfg() {
...
eni_cfg = (plca_cfg->enabled) ? NCN26000_PHYCFG1_ENI : 0;
return phy_modify_mmd(phydev, MDIO_MMD_VEND2,
NCN26000_REG_PHYCFG1,
NCN26000_PHYCFG1_ENI, eni_cfg);
}
The S2500 MAC driver gives the same MMS4 register a different name, and
does not define an ENI bit for it:
drivers/net/ethernet/onsemi/s2500/s2500_hw_def.h:
#define S2500_REG_VS_TWEAKS1 0x8001
The commit message covers one PLCA difference between the two parts (the
TO_TIMER default). It does not say whether TWEAKS1[7] has the same ENI
meaning on the S2500.
If the meaning differs, each ethtool PLCA enable or disable would toggle
an unrelated vendor tuning bit through this path:
phy_ethtool_set_plca_cfg()->ncn26000_c45_plca_set_cfg()->phy_modify_mmd()
Could this be confirmed in the commit message or in a comment? If the bit
is different on the S2500, the entry could call genphy_c45_plca_set_cfg()
directly instead.
> + .get_plca_cfg = genphy_c45_plca_get_cfg,
> + .get_plca_status = genphy_c45_plca_get_status,
> + .soft_reset = genphy_soft_reset,
[ ... ]
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113-s2500-mac-phy-support-v11-0-7a186141952c%40onsemi.com
next prev parent reply other threads:[~2026-11-17 19:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 16:59 [PATCH net-next v11 00/14] (no cover subject) Selvamani Rajagopal via B4 Relay
2026-11-13 16:59 ` [PATCH net-next v11 01/14] dt-bindings: net: add onsemi's S2500 Selvamani Rajagopal via B4 Relay
2026-11-13 16:59 ` [PATCH net-next v11 02/14] Documentation: networking: Add timestamp related APIs to OA TC6 framework Selvamani Rajagopal via B4 Relay
2026-11-13 16:59 ` [PATCH net-next v11 03/14] net: ethernet: oa_tc6: Move oa_tc6.c to its own directory Selvamani Rajagopal via B4 Relay
2026-11-17 19:52 ` netdev-bot+sashiko
2026-11-13 16:59 ` [PATCH net-next v11 04/14] net: ethernet: oa_tc6: Move constant definitions to header file Selvamani Rajagopal via B4 Relay
2026-11-13 16:59 ` [PATCH net-next v11 05/14] net: ethernet: microchip: lan865x: Depends on PTP_1588_CLOCK_OPTIONAL Selvamani Rajagopal via B4 Relay
2026-11-17 19:53 ` netdev-bot+sashiko
2026-11-13 16:59 ` [PATCH net-next v11 06/14] net: ethernet: adi: adin1140: " Selvamani Rajagopal via B4 Relay
2026-11-13 16:59 ` [PATCH net-next v11 07/14] net: ethernet: oa_tc6: Support for hardware timestamp Selvamani Rajagopal via B4 Relay
2026-11-17 19:53 ` netdev-bot+sashiko
2026-11-13 16:59 ` [PATCH net-next v11 08/14] net: ethernet: oa_tc6: Drop frames if footer has FD bit set Selvamani Rajagopal via B4 Relay
2026-11-17 19:53 ` netdev-bot+sashiko
2026-11-13 16:59 ` [PATCH net-next v11 09/14] net: phy: ncn26000: Enable enhanced noise immunity Selvamani Rajagopal via B4 Relay
2026-11-13 16:59 ` [PATCH net-next v11 10/14] net: ethernet: onsemi: s2500: Add driver support for S2500 Selvamani Rajagopal via B4 Relay
2026-11-16 22:34 ` Selvamani Rajagopal
2026-11-17 1:44 ` Andrew Lunn
2026-11-17 1:54 ` Selvamani Rajagopal
2026-11-17 19:53 ` netdev-bot+sashiko
2026-11-13 16:59 ` [PATCH net-next v11 11/14] net: ethernet: onsemi: s2500: Add selftest support Selvamani Rajagopal via B4 Relay
2026-11-13 16:59 ` [PATCH net-next v11 12/14] net: phy: Add helper to modify only the PHY loopback bit Selvamani Rajagopal via B4 Relay
2026-11-13 16:59 ` [PATCH net-next v11 13/14] net: phy: ncn26000: Support for onsemi's S2500 internal phy Selvamani Rajagopal via B4 Relay
2026-11-17 19:53 ` netdev-bot+sashiko [this message]
2026-11-13 16:59 ` [PATCH net-next v11 14/14] net: phy: dp83867: Use genphy_loopback_no_speed() Selvamani Rajagopal via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179494518788.3136.14432777334635452577@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=Selvamani.Rajagopal@onsemi.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=ciprian.regus@analog.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jerry.ray@microchip.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parthiban.veerasooran@microchip.com \
--cc=piergiorgio.beruto@gmail.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox