From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752969AbXDVWqb (ORCPT ); Sun, 22 Apr 2007 18:46:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753289AbXDVWqb (ORCPT ); Sun, 22 Apr 2007 18:46:31 -0400 Received: from ozlabs.org ([203.10.76.45]:33444 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753014AbXDVWqb (ORCPT ); Sun, 22 Apr 2007 18:46:31 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17963.58820.295008.169336@cargo.ozlabs.ibm.com> Date: Mon, 23 Apr 2007 08:46:28 +1000 From: Paul Mackerras To: Christoph Hellwig Cc: "Eric W. Biederman" , ", containers@lists.osdl.org, Oleg Nesterov , linux-kernel@vger.kernel.org, Benjamin Herrenschmidt Subject: Re: [PATCH] macintosh/therm_pm72.c: Convert to kthread API. In-Reply-To: <20070422191647.GA14995@infradead.org> References: <11769695832169-git-send-email-ebiederm@xmission.com> <20070422191647.GA14995@infradead.org> X-Mailer: VM 7.19 under Emacs 21.4.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig writes: > Why is this driver using a thread at all? It's only doing a bunch > of rather short-lived things in the thread. It's doing i2c reads and writes, which block, and are actually quite slow. Paul.