From: "Martin J. Bligh" <Martin.Bligh@us.ibm.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] fix timer interrupts on NUMA-Q
Date: Wed, 10 Jul 2002 17:37:47 -0700 [thread overview]
Message-ID: <179860000.1026347867@flay> (raw)
Since I turned on the IO-APICs on secondary quads, we are receiving
timer interrupts on *all* quads, not just the first quad, each from their
local timer chip. This causes time to progress far too rapidly ;-)
The simple patch below turns off the timer interrupts for IO-APICs other
than interrupt 0, and has been tested to fix the problem. As it switches
on clustered_apic_mode, it should be safe from hurting anyone else.
This fix is already in 2.4 - I'm playing catchup with 2.5 - the same patch
applies with just a line offset
Please apply ...
Thanks,
Martin.
diff -urN virgin-2.4.19-pre8/arch/i386/kernel/io_apic.c linux-2.4.19-pre8-time/arch/i386/kernel/io_apic.c
--- virgin-2.4.19-pre8/arch/i386/kernel/io_apic.c Tue May 7 15:21:16 2002
+++ linux-2.4.19-pre8-time/arch/i386/kernel/io_apic.c Thu May 9 17:49:28 2002
@@ -654,7 +654,14 @@
}
irq = pin_2_irq(idx, apic, pin);
- add_pin_to_irq(irq, apic, pin);
+ /*
+ * skip adding the timer int on secondary nodes, which causes
+ * a small but painful rift in the time-space continuum
+ */
+ if (clustered_apic_mode && (apic != 0) && (irq == 0))
+ continue;
+ else
+ add_pin_to_irq(irq, apic, pin);
if (!apic && !IO_APIC_IRQ(irq))
continue;
reply other threads:[~2002-07-11 0:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179860000.1026347867@flay \
--to=martin.bligh@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox