From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74038C43441 for ; Wed, 14 Nov 2018 20:22:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A15021780 for ; Wed, 14 Nov 2018 20:22:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="a4OeI8tt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A15021780 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731119AbeKOG1M (ORCPT ); Thu, 15 Nov 2018 01:27:12 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:43630 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725757AbeKOG1M (ORCPT ); Thu, 15 Nov 2018 01:27:12 -0500 Received: from avalon.localnet (unknown [64.114.255.97]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F0151BB8; Wed, 14 Nov 2018 21:22:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1542226948; bh=XKzOdI+MGBR0wmwH3+m3c7FX3EIB45dcQYa2lx3hLnc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a4OeI8ttom9y5z/pvIYoJGzZ+c04j1LFNWJfHebnsed8LMeoaJjsUgtqUwHb5f7kq Dyrzm/7Smv05s8YbouFjSPgOMPEUR2vX1WpjvpuDZRdCTr0i3flVZCGf25Pxa0pAZB 6PmtZ223zkRtvVjjmsTnGRCI2N56a54rp+BfYlFY= From: Laurent Pinchart To: Luis Oliveira Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, joao.pinto@synopsys.com, festevam@gmail.com, Mauro Carvalho Chehab , Greg Kroah-Hartman , "David S. Miller" , Andrew Morton , Arnd Bergmann , Hans Verkuil , Geert Uytterhoeven , Neil Armstrong , Philipp Zabel , Thierry Reding , Maxime Ripard , Todor Tomov Subject: Re: [V3, 4/4] media: platform: dwc: Add MIPI CSI-2 controller driver Date: Wed, 14 Nov 2018 22:22:39 +0200 Message-ID: <1798955.5kaMj8jiTI@avalon> Organization: Ideas on Board Oy In-Reply-To: <1539953556-35762-5-git-send-email-lolivei@synopsys.com> References: <1539953556-35762-1-git-send-email-lolivei@synopsys.com> <1539953556-35762-5-git-send-email-lolivei@synopsys.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Luis, Thank you for the patch. On Friday, 19 October 2018 15:52:26 EET Luis Oliveira wrote: > Add the Synopsys MIPI CSI-2 controller driver. This > controller driver is divided in platform dependent functions > and core functions. It also includes a platform for future > DesignWare drivers. > > Signed-off-by: Luis Oliveira > --- > Changelog > v2-V3 > - exposed IPI settings to userspace Could you please explain why you need this and can't use standard APIs ? Custom sysfs attributes are needed, they need to be documented in Documentation/ABI/. > - fixed headers > > MAINTAINERS | 11 + > drivers/media/platform/dwc/Kconfig | 30 +- > drivers/media/platform/dwc/Makefile | 2 + > drivers/media/platform/dwc/dw-csi-plat.c | 699 ++++++++++++++++++++++++++++ > drivers/media/platform/dwc/dw-csi-plat.h | 77 ++++ > drivers/media/platform/dwc/dw-mipi-csi.c | 494 ++++++++++++++++++++++ > drivers/media/platform/dwc/dw-mipi-csi.h | 202 +++++++++ > include/media/dwc/dw-mipi-csi-pltfrm.h | 102 +++++ > 8 files changed, 1616 insertions(+), 1 deletion(-) > create mode 100644 drivers/media/platform/dwc/dw-csi-plat.c > create mode 100644 drivers/media/platform/dwc/dw-csi-plat.h > create mode 100644 drivers/media/platform/dwc/dw-mipi-csi.c > create mode 100644 drivers/media/platform/dwc/dw-mipi-csi.h > create mode 100644 include/media/dwc/dw-mipi-csi-pltfrm.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index da2e509..fd5f1fc 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -14032,6 +14032,16 @@ S: Maintained > F: drivers/dma/dwi-axi-dmac/ > F: Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt > > +SYNOPSYS DESIGNWARE MIPI CSI-2 HOST VIDEO PLATFORM > +M: Luis Oliveira > +L: linux-media@vger.kernel.org > +T: git git://linuxtv.org/media_tree.git > +S: Maintained > +F: drivers/media/platform/dwc > +F: include/media/dwc/dw-mipi-csi-pltfrm.h > +F: Documentation/devicetree/bindings/media/snps,dw-csi-plat.txt > +F: Documentation/devicetree/bindings/phy/snps,dphy-rx.txt These two lines belong to patches 1/4 and 3/4. Doesn't checkpatch.pl warn about this ? Now that I mentioned checkpatch.pl, I tried running it on this series, and it generates a fair number of warnings and errors. Could you please fix them ? > + > SYNOPSYS DESIGNWARE DMAC DRIVER > M: Viresh Kumar > R: Andy Shevchenko > @@ -16217,3 +16227,4 @@ T: git > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git S: Buried > alive in reporters > F: * > F: */ > + Stray new line. [snip] -- Regards, Laurent Pinchart