From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 557BA158545 for ; Mon, 17 Feb 2025 19:23:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739820217; cv=none; b=c7biXERfNElzCJQdLIXYDtg2WnpxMKON7q7G1WXnVqCIveZngNM8DNCrzmAkyyQXvL7tQYuIRXOtngoGb+pI5HtStJIEi3nV6NGQZJWJZVUjMTHLkeZXu6WaEk9b6uuTod9r2eblud34JneQZ3SYKDHqJWg3qo87NQULNyQmRcc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739820217; c=relaxed/simple; bh=2Nq3JUri+KI/06XtoGRs5UIrCElEWxYTvjfNOTr8uMc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fwF5DWaw3rKpTr9bbDCbEtL/MVJuhfec7pOgJwYhBgh3Y5a20s3cTexjaHga8DFzKBvQ7Z9QDoFpobF6occ9UQCNkWScmiroHrp8QgsBNd/c2Olt9NqLyLegGl4jYoMQmPnx2CHj+Tv50q+bzJtgQtPOHZRzYo2y0u3QrOrM71o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=icZKC+jD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="icZKC+jD" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51HAbWFb017096 for ; Mon, 17 Feb 2025 19:23:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= f3R0RsP0qxokYAsUiXTvj2ecPRgqSEuNFAQ4ClnwXpI=; b=icZKC+jD4T/KkWYA gTMeDv6qsvGIZyOunAsNrZrqPkNtYqgZ7lVOdryXcTT6P47IrMiiu+ULBSfLoi5j gMPDGjRiDBxILNhdthAKocdJOi4AGxNYb9cP1mpy5PNr7l+bp/Ak4A5juIxPWVng MZXnUY5cItjh1Xfb42/ahY86in7ZN0pwNccmL5UcIonUmCG1Jz+4jxuD/8zsEwWi DgCnqQ07FPJ4snpDPUBI9L8AiKQ52O0mlkODIBJwW335jEogIP/iNa22GXzycypS MvGKNkceL6c/BFsA6cqYBbY24vknSZpGtX0KyshTmaadDZzb5Hpq+Qrrag+RuE/N eq6xxg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44ut7utn38-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 17 Feb 2025 19:23:34 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7c09a206998so8560785a.2 for ; Mon, 17 Feb 2025 11:23:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739820214; x=1740425014; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f3R0RsP0qxokYAsUiXTvj2ecPRgqSEuNFAQ4ClnwXpI=; b=IXreEk3Ps8YUIAxTw22+PXVOtabQDAtgTFOsBYTtvsoQnq9eFMJM55zbnMscKDjuTk KFEbgr5kOar9SVnlTawzEJrcLA13mMbcmuqCvoLShppVJ76r7gtz/UezcIe4RJgV3LMQ zAlnSUrAHBLYP2OlXChYAJg2PEY5UxcPyDSsriW0aUYL8FHu23d/hnb21V9FFpTs9MjZ QjGg+Cv1uiF9mpjdNR2XTallAYQPZaYvklrkh/nt9mfHRlE3ZEv3hsaXd0Cah4ctnns1 JRkN3Bl8dRNx0DRCI8RSATWGc1dnE6PjL/5zavSQ8Kr1l94wU8jA3L9jHcrozAfK+svZ rQhw== X-Forwarded-Encrypted: i=1; AJvYcCWKhydZPUHoSJVbQoLvO7AjU66DicnOTPQCU7+X2w2kA3CB2FtRLEJiGi+3xTOpRuCMTg9NRUh5Vszfn64=@vger.kernel.org X-Gm-Message-State: AOJu0YwjEUgZXtIJBcN7jXxD0a8vQEKIX+bO7ah4ArN0Ik6HIt+EQoED 7aQ454outDcDS4rs4V8xbrfeRCl9yOuvg4w3eKey4A9GryybFKYi9gQopwjH1UzCK9sSRdg9jxq o/XsHuC+/5tw3hpoFFzpesyAQohZEsjGvufo69jERW3Y2NcdRgo5MMG3uM88+Ato= X-Gm-Gg: ASbGnctznQikVibFszShYyIo6q7HDdftlHS/CxRaKlNz6a6evE/JoAfnHj5cAP57Ky9 VCe323B2zdzN9B710bSgir2h8XjD34fTZ9ikQbra/eQ5/0HHQJR4rWNexQ5YfCG8lX8aIU1mR96 e+c4cqE0fZFv12XegpNXscfBSwbHbNRsIT+n7rA+QDIDCzhYpIGGusZid4MGH1ugAHpfbNrZrez hRP5mFVw+ejNb3cjb+b9cIfes5en7xr0ePFGoA3VsPc9dc6LYddGU6IZZ7eu7rP+4XaxFUhGEL3 RqQFl5W0aSpJ+gth+/MQ0qIY5QLysAPld5Xf3AbOEbizFr4n6PNmAKYS0SI= X-Received: by 2002:a05:620a:4114:b0:7b6:d2ca:15b6 with SMTP id af79cd13be357-7c08a894ef5mr568444885a.0.1739820214231; Mon, 17 Feb 2025 11:23:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IGzRMmoNE160cgaxdnNq2csM6qzlbbuPrQJrTqF0PQj/u94i3U0EsIFyC0sFwqX+gBrUlh8yQ== X-Received: by 2002:a05:620a:4114:b0:7b6:d2ca:15b6 with SMTP id af79cd13be357-7c08a894ef5mr568442385a.0.1739820213788; Mon, 17 Feb 2025 11:23:33 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5451f09ab65sm1702580e87.82.2025.02.17.11.23.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Feb 2025 11:23:32 -0800 (PST) Message-ID: <17aa47df-1daf-4ec2-8f6a-48c3bc375dd3@oss.qualcomm.com> Date: Mon, 17 Feb 2025 20:23:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] arm64: dts: qcom: sar2130p: add PCIe EP device nodes To: Dmitry Baryshkov , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Mrinmay Sarkar , Bjorn Andersson , Konrad Dybcio Cc: =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250217-sar2130p-pci-v1-0-94b20ec70a14@linaro.org> <20250217-sar2130p-pci-v1-5-94b20ec70a14@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250217-sar2130p-pci-v1-5-94b20ec70a14@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: uX1vb6r35MtPTcV39_3WAZtV4NEgdhzD X-Proofpoint-ORIG-GUID: uX1vb6r35MtPTcV39_3WAZtV4NEgdhzD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-17_08,2025-02-13_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxlogscore=999 spamscore=0 clxscore=1015 malwarescore=0 bulkscore=0 mlxscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502170152 On 17.02.2025 7:56 PM, Dmitry Baryshkov wrote: > On the Qualcomm AR2 Gen1 platform the second PCIe host can be used > either as an RC or as an EP device. Add device node for the PCIe EP. > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sar2130p.dtsi | 53 ++++++++++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sar2130p.dtsi b/arch/arm64/boot/dts/qcom/sar2130p.dtsi > index dd832e6816be85817fd1ecc853f8d4c800826bc4..7f007fad6eceebac1b2a863d9f85f2ce3dfb926a 100644 > --- a/arch/arm64/boot/dts/qcom/sar2130p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sar2130p.dtsi > @@ -1474,6 +1474,59 @@ pcie@0 { > }; > }; > > + pcie1_ep: pcie-ep@1c08000 { > + compatible = "qcom,sar2130p-pcie-ep"; > + reg = <0x0 0x01c08000 0x0 0x3000>, > + <0x0 0x40000000 0x0 0xf1d>, > + <0x0 0x40000f20 0x0 0xa8>, > + <0x0 0x40001000 0x0 0x1000>, > + <0x0 0x40200000 0x0 0x1000000>, > + <0x0 0x01c0b000 0x0 0x1000>, > + <0x0 0x40002000 0x0 0x2000>; > + reg-names = "parf", "dbi", "elbi", "atu", "addr_space", > + "mmio", "dma"; vertical list, please > + > + clocks = <&gcc GCC_PCIE_1_AUX_CLK>, > + <&gcc GCC_PCIE_1_CFG_AHB_CLK>, > + <&gcc GCC_PCIE_1_MSTR_AXI_CLK>, > + <&gcc GCC_PCIE_1_SLV_AXI_CLK>, > + <&gcc GCC_PCIE_1_SLV_Q2A_AXI_CLK>, > + <&gcc GCC_DDRSS_PCIE_SF_CLK>, > + <&gcc GCC_AGGRE_NOC_PCIE_1_AXI_CLK>, > + <&gcc GCC_CFG_NOC_PCIE_ANOC_AHB_CLK>, > + <&gcc GCC_QMIP_PCIE_AHB_CLK>; please make sure this one is actually required > + clock-names = "aux", > + "cfg", > + "bus_master", > + "bus_slave", > + "slave_q2a", > + "ddrss_sf_tbu", > + "aggre_noc_axi", > + "cnoc_sf_axi", > + "qmip_pcie_ahb"; > + > + interrupts = , > + , > + ; > + interrupt-names = "global", "doorbell", "dma"; and here > + > + interconnects = <&pcie_noc MASTER_PCIE_1 QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, > + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS > + &config_noc SLAVE_PCIE_1 QCOM_ICC_TAG_ALWAYS>; active-only looks good otherwise Konrad