From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E449C44B692 for ; Tue, 28 Apr 2026 14:23:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777386223; cv=none; b=r3KjEcXCMZ5QyXmoWk1oofGvvHrhu7y6/tf1+ByJm/mrftj6C1K8brMXIv2ZjwhIfAzM3kCGSYcPBRA4Qjqd13AeW+3ZLQggE+yMALibaHssEUJnPgmCDl2G3WrHrYYSf655I7LfTRUrzUYvB0YEFdSC2fMEpk7ElQe2m0Pn64M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777386223; c=relaxed/simple; bh=2YNsiTXzXOv2m74/OS8Ei+h+JPVuKtHh0iQ7A9nDFxs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NtlasPuJ89lM7HF8wvrfMfmM7A8gotKwBbDXyIeWKcyFAzdGAlFDR9o39p5E4H71sbeKQwIVhH1iirjndDM/9KCX5Qaz5+HwLbFgPdNJ3VGvXsNm4GI+tqdEjShC7YaZgHnwbvRgaXupxxy2IeIW1KVAa06FOEKaIcQDeuR2iJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YeSWX8zH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PepiAa20; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YeSWX8zH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PepiAa20" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63SA3ubY3274994 for ; Tue, 28 Apr 2026 14:23:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jmxuff+2VurCFsBMSjVHjuC/5j3liv6ORO4lRuTXi1A=; b=YeSWX8zHTFpVjfOZ 1TvwasJuLc6tZR6qWVFZ5/D+VqQMOc5XEvweZtcjneATHIW6Qam1L/asVbiW3AFZ 26ZbDI5WXvtwX75MY9/gSWNQZ81zHkfIhQT9B0H8JthJVrJ3ECPsvANPZwBTtYC0 rfCzp4COezjGHZsbLcyvA+x45yKA151lSZTykgAGtkd+lnzXjjkPRKZwoGH58sx3 4nU9qonJVXMWLo1C6xMuYNaY7IrL48Aam/0GCGn/EM/YdT9ZeL3OSeeqxAzhr6XM lq0NmTjSP34soslkXXI37NPJo0HbNZsMFHnRwBoFdVIo5R7Q7h9SiR/oIdiwqz7r wyvXAg== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dtttjgy7k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Apr 2026 14:23:35 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-2e60238adb1so28736760eec.0 for ; Tue, 28 Apr 2026 07:23:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777386214; x=1777991014; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jmxuff+2VurCFsBMSjVHjuC/5j3liv6ORO4lRuTXi1A=; b=PepiAa20QXOwsbUCYBuK/ape8Nz2spomDgKN6X3hemnWovCIG9/OO48ohMtjrY4TrT HeGuWYc3+NI639YOoa4C7lfNCRXIMAzo9X/Ng2TDM0cwUvv/UriqXMToA+aed98B4F4n GCmCpsuw/T6sQ717FXUAptQDo1K0TpKa4cUmIPAfoXNAeiYnDxlln48ROOpYS8og9GtC jrpqy3fXUknZMNHzM4YZrk/NgVL8et8Rt3LtS1oUzMfAJZQuxq+CRH/BM/z2lDGG8/tS Af0jQceVsBYoEuk6eQ682wR0F3X5QzB+LYFLd9gs8lng/5u6a8+lLgitl/OS7UJuaHaC 8GQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777386214; x=1777991014; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jmxuff+2VurCFsBMSjVHjuC/5j3liv6ORO4lRuTXi1A=; b=F6dvOH7MJYrU49QyEPB5FiJNCo5evx1r+8zQTJhfGFDig6AzGQOLyL/mhjoxAb8jKV A7KOvnep6Wl11SE62cLFt6SADBl+KLBmnuJjbanDPhVoiu5kAOxrb5eLFgk3msld7iCd ttdM8ZvG3MlyWosVQhDCbNaEITT/PN7hHFF1gqCu3cB0Mg+R4lnDhZfYpgUPupvsvk8h foSw1MpDSSEANCZp3jsbHWKP4Ph44XVCQNvoCawg7Zdor7Ew9tdbSEvwTIpQk/OMs0dA 21RHAZrsv64KFHd/Yu+fbFYjVKXbrs3/npYU2ccSQ+ehX1kzLYAYPW8Ep3wuTLbbB4GD MLrA== X-Forwarded-Encrypted: i=1; AFNElJ99lUlBxBo/nMJVskqLRow8609+FROKn2j62qqHaqLrV+R8PBsi795SebHdr/ShamIyiLE+aFIYmExQHE4=@vger.kernel.org X-Gm-Message-State: AOJu0YxDUYfuzLHKgGqhGNrcwRilAbM1N8cJvYr/jwh+sJMIdAJv4qEs X8izqyN9sniy+JIoiUFXUSUT0kbTFpNy/NG/Lh20EWTIrTC30aOsYfdOLwPoI72qROinlZDAPeh wn6ugkK2luN7Kh8n2+RVEfiKCj5GGrHDG/XhJuzU8Raic5W2nxsQpnpgNUK/qRMS5yBbc44j1RP w= X-Gm-Gg: AeBDieu/+NXrPaLNCap9i9+fsV04Lcjxj5PWeFXPWvBKKTMRxdE129/S3+HIT5rDy4m vRbX2SGDbdPsjEgUTAfrq36SX8WQxjIHPNR9GymR4ME+xy6p+Re2Q0JkzKQ5RsPFigzNmnPawFA sFv7hlyOWxY3U3Iw0WhawEIhubfA2ENOtfCZ/ZWzqMAdOocpdP0Sgbc0N6PzT1RtdsPlvm5DyCQ dv2YblNsQB04lzUl/3lPCSuTmUqi7DtKkm/hGg2tJ3f81hH/lUpJ2rP06n+rRqGNdexKN4JvIDv TasBAyuQLXD7WS/YODHoFdzevFg/NaJkleCWZXU3rBJPzjV28L1iRY8zkrEgXFPPIBxvrR7bqVX MXGelfVyRzF1+LUCfvl9Al8pyOTEJll3PMT653KFVBKslR/67D6nb8MHBX0zaE8p8PTZub2eF/+ Zeuknn2AdQ7IF8Rm40zQyW0OOB X-Received: by 2002:a05:7300:a148:b0:2ca:8099:ffc0 with SMTP id 5a478bee46e88-2ed09fcf030mr1547168eec.7.1777386214150; Tue, 28 Apr 2026 07:23:34 -0700 (PDT) X-Received: by 2002:a05:7300:a148:b0:2ca:8099:ffc0 with SMTP id 5a478bee46e88-2ed09fcf030mr1547152eec.7.1777386213538; Tue, 28 Apr 2026 07:23:33 -0700 (PDT) Received: from [192.168.1.47] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ed0a10678csm2467904eec.24.2026.04.28.07.23.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 07:23:32 -0700 (PDT) Message-ID: <17d5b91c-026f-4539-a39a-cfd976860273@oss.qualcomm.com> Date: Tue, 28 Apr 2026 07:23:30 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: mac80211: drop stray 'static' from fast-RX rx_result To: Catherine , linux-wireless@vger.kernel.org, Felix Fietkau Cc: johannes@sipsolutions.net, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260424131435.83212-2-enderaoelyther@gmail.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20260424131435.83212-2-enderaoelyther@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI4MDEzNiBTYWx0ZWRfX1Lyeg+BIxwP7 sOAdGWZBYgoDtngmdzlhE6WoVCbugujcWLBjzedVQw3r40fFa9IaD71x1Gp3ro0i9YsF14X8y3o xJpztLt+y13MedZt3q5WzbWxJFwYSXkL4cu6+PXjVKvSZUZoyhVGGqeBCeqfYdRKLUP+V04Oba5 y5+IWfYAZhfOI9juufeSJY0EXQp5mUWS8WkazxCTTzhHDLT4nFKt1I8lIIg4Z+J0uI6N2uH2Ffl M247QbltaHJ6rTiXyI1B/7XCxbaNNwYMtMbXivzqcbZT115KhpMTJqVkDgOdhA/RDnDHSlSxkBL +ImXkFsNhLMGWNjq4jKzUwRsLh/loNytah0sZ3GfE9l7PT0eVpkuZz7csyjePtSZbyBI4jMqBsD BsCRsmHaHFw4GekK1COTfA/cYTy7l9qSX8QEciwz43I4j1JaZi3YHnfHvYdMur0mCy2SbNRgzER +pGwKWlPgkl8DtMKCGQ== X-Authority-Analysis: v=2.4 cv=TZKmcxQh c=1 sm=1 tr=0 ts=69f0c2e7 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=vluirgkKQf0QiLCMEdgA:9 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-GUID: QdIzBuyAIEpXkSwg0INl9xczrLosZeE6 X-Proofpoint-ORIG-GUID: QdIzBuyAIEpXkSwg0INl9xczrLosZeE6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-28_04,2026-04-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 adultscore=0 phishscore=0 clxscore=1015 suspectscore=0 bulkscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604280136 On 4/24/2026 6:14 AM, Catherine wrote: > ieee80211_invoke_fast_rx() is documented as safe for parallel RX, but > its per-invocation rx_result is declared static. Concurrent callers then > share one instance and can overwrite each other's result between > ieee80211_rx_mesh_data() and the switch on res. > > That can make a packet that was queued or consumed by > ieee80211_rx_mesh_data() fall through into ieee80211_rx_8023(), or make > a packet that should continue return as queued. > > Make res an automatic variable so each invocation keeps its own result. > > Fixes: 3468e1e0c639 ("wifi: mac80211: add mesh fast-rx support") @Felix: Any recollection why this was static in your original patch? > Cc: stable@vger.kernel.org > Signed-off-by: Catherine Is this an identity you commonly use? Note that anonymous contributions are not allowed: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1 > --- > net/mac80211/rx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c > index 3e5d1c47a..8719db8f3 100644 > --- a/net/mac80211/rx.c > +++ b/net/mac80211/rx.c > @@ -4971,7 +4971,7 @@ static bool ieee80211_invoke_fast_rx(struct ieee80211_rx_data *rx, > struct sk_buff *skb = rx->skb; > struct ieee80211_hdr *hdr = (void *)skb->data; > struct ieee80211_rx_status *status = IEEE80211_SKB_RXCB(skb); > - static ieee80211_rx_result res; > + ieee80211_rx_result res; > int orig_len = skb->len; > int hdrlen = ieee80211_hdrlen(hdr->frame_control); > int snap_offs = hdrlen; Actual patch seem reasonable.. Reviewed-by: Jeff Johnson