From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20D52C43331 for ; Sat, 7 Sep 2019 05:28:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F09E5206A1 for ; Sat, 7 Sep 2019 05:28:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389786AbfIGF2U (ORCPT ); Sat, 7 Sep 2019 01:28:20 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38278 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729409AbfIGF2U (ORCPT ); Sat, 7 Sep 2019 01:28:20 -0400 Received: by mail-wm1-f68.google.com with SMTP id o184so9152604wme.3; Fri, 06 Sep 2019 22:28:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bt3oijoWvAOEh03WYLlldB6hYRNYY3O8b2uPfoxZoNk=; b=EtznzTmLSlM5CNoUxGGrhPHLpP1M8iQCqEwiDIDwaacXzHAqcxaJz0g8PiBZ/PmSGN KwIoihzRvm5Kr+ktystoL8IJKury1nGoxtdl1nGgUFmzg+SzoZmtdTJy4hMoZxcixWrq kG3pSl4D2JKStv6qTR6d+r3GS9/rgEJAOd64s/Tk81FhX8GuNQVe48e4BM6xCqe8lak1 +6xPxVQXa1taAmKrMmibLFDmkjZEJzc2VV+cDMXfIaOzF/zCiYEYGNYwy3aqwyZPTqtk hv7yUVNYRR86FZCRk71MyrZMXB9w5uV4Mv33AiLAv9qSO1HVZ9WANxPaxVqHCuWwWhkS irZw== X-Gm-Message-State: APjAAAXKLFXcbMw78eX2gY3BwA6Z3M+LDEgpnBaFctEZHe2cvirk9RyH IzUzkWkuf7GkVqbQ4ipIOlvvGnQp X-Google-Smtp-Source: APXvYqxdPBh5b9x/+TgH0lYPPyu6z0h4wvwg9UJYfVUYrW97GEkj4StuAz96t2EjImcrgpDPxeExjQ== X-Received: by 2002:a7b:cc86:: with SMTP id p6mr9330019wma.136.1567834097793; Fri, 06 Sep 2019 22:28:17 -0700 (PDT) Received: from [10.68.32.192] (broadband-188-32-48-208.ip.moscow.rt.ru. [188.32.48.208]) by smtp.gmail.com with ESMTPSA id r9sm11541452wra.19.2019.09.06.22.28.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Sep 2019 22:28:17 -0700 (PDT) Subject: Re: [PATCH] mostpost: don't warn about symbols from another file From: Denis Efremov To: Arnd Bergmann , Masahiro Yamada , Michal Marek Cc: Emil Velikov , Paul Walmsley , Sam Ravnborg , WANG Chao , Sami Tolvanen , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190906151059.1077708-1-arnd@arndb.de> <7fc19dd4-93fb-fa15-3d36-3079cd42cf7c@linux.com> Message-ID: <17ee4877-d24a-12ad-5836-411e3e525933@linux.com> Date: Sat, 7 Sep 2019 08:28:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: <7fc19dd4-93fb-fa15-3d36-3079cd42cf7c@linux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07.09.2019 01:39, Denis Efremov wrote: > Hi, > > On 06.09.2019 18:10, Arnd Bergmann wrote: >> On architectures such as ARM that have a list of symbols exported from >> assembler in a separate C file, we get a lot of new warnings: >> >> WARNING: "__ashrdi3" [vmlinux] is a static (unknown) >> WARNING: "__lshrdi3" [vmlinux] is a static (unknown) >> WARNING: "__aeabi_llsr" [vmlinux] is a static (unknown) >> WARNING: "__aeabi_lasr" [vmlinux] is a static (unknown) >> WARNING: "__aeabi_uidivmod" [vmlinux] is a static (unknown) >> WARNING: "__udivsi3" [vmlinux] is a static (unknown) >> WARNING: "_change_bit" [vmlinux] is a static (unknown) >> WARNING: "__aeabi_idiv" [vmlinux] is a static (unknown) >> WARNING: "__umodsi3" [vmlinux] is a static (unknown) >> WARNING: "__aeabi_uidiv" [vmlinux] is a static (unknown) >> WARNING: "__aeabi_idivmod" [vmlinux] is a static (unknown) >> WARNING: "__muldi3" [vmlinux] is a static (unknown) >> WARNING: "__aeabi_ulcmp" [vmlinux] is a static (unknown) >> WARNING: "__raw_writesb" [vmlinux] is a static (unknown) >> WARNING: "__raw_readsb" [vmlinux] is a static (unknown) >> ... >> >> This is not helpful, as these are clearly not static symbols >> at all. Suppress the warning in a case like this. >> > > It looks very similar to this discussion https://lkml.org/lkml/2019/7/30/112 > > Could you please write the steps to reproduce the warnings? > Now, I'm trying to build linux-next (host Ubuntu 19.04 x86_64) with: > $ make ARCH=arm CROSS_COMPILE=/usr/bin/arm-linux-gnueabi- > But I can't get these warnings. Tried defconfig, allyesconfig. > > I would like to check the type of this asm symbols. It seems like they > are STT_NOTYPE. In this case the fix could also involve ELF_ST_TYPE check. > Ah, I forgot that we don't check the type at all, so this is not the case. But still, I would like to test what if the remove binding check at all? diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 76c221dd9b2b..97dbcebf2338 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1987,14 +1987,12 @@ static void read_symbols(const char *modname) for (sym = info.symtab_start; sym < info.symtab_stop; sym++) { unsigned char bind = ELF_ST_BIND(sym->st_info); - if (bind == STB_GLOBAL || bind == STB_WEAK) { struct symbol *s = find_symbol(remove_dot(info.strtab + sym->st_name)); if (s) s->is_static = 0; - } } if (!is_vmlinux(modname) || vmlinux_section_warnings) Thanks, Denis > >> Fixes: 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* functions") >> Signed-off-by: Arnd Bergmann >> --- >> scripts/mod/modpost.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c >> index 76c221dd9b2b..4265dd924933 100644 >> --- a/scripts/mod/modpost.c >> +++ b/scripts/mod/modpost.c >> @@ -2543,7 +2543,7 @@ int main(int argc, char **argv) >> struct symbol *s = symbolhash[n]; >> >> while (s) { >> - if (s->is_static) >> + if (s->is_static && s->export != export_unknown) >> warn("\"%s\" [%s] is a static %s\n", >> s->name, s->module->name, >> export_str(s->export)); >>