From: Stefan Agner <stefan@agner.ch>
To: Alexander Stein <alexander.stein@systec-electronic.com>,
Meng Yi <meng.yi@nxp.com>
Cc: linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
airlied@redhat.com
Subject: Re: fsl-dcu not works on latest "drm-next"
Date: Fri, 03 Jun 2016 15:52:01 -0700 [thread overview]
Message-ID: <17f0bd63a0efebefb30f10ff208da9bd@agner.ch> (raw)
In-Reply-To: <2397536.bIp6BuhYPD@ws-stein>
On 2016-05-26 02:11, Alexander Stein wrote:
> On Thursday 26 May 2016 08:23:42, Meng Yi wrote:
>> Hi Mark,
>>
>> > You've not specifically described the problem here - what are the
>> > endiannesses of both the CPU and the device you're talking to? What
>> > specifically is the endianess problem you are seeing, what are you seeing
>> > and what do you expect to see?
>>
>> The CPU is little endian and the device DCU is big endian, specified
>> big-endian in DTS,
>>
>> And here is my DTS and regmap_config,
>>
>> Specified "big-endian" in DTS,
>>
>> dcu: dcu@2ce0000 {
>> compatible = "fsl,ls1021a-dcu";
>> reg = <0x0 0x2ce0000 0x0 0x10000>;
>> interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
>> clocks = <&platform_clk 0>;
>> clock-names = "dcu";
>> big-endian;
>> status = "disabled";
>> };
>>
>> I can't tell the difference of "reg_format_endian" and " val_format_endian
>> ", so I had tried four conditions. And all failed.
>>
>> static const struct regmap_config fsl_dcu_regmap_config = {
>> .reg_bits = 32,
>> .reg_stride = 4,
>> .val_bits = 32,
>> .cache_type = REGCACHE_RBTREE,
>
> This needs to be a flat cache. See
> https://lists.freedesktop.org/archives/dri-devel/2016-January/099121.html
> or https://lkml.org/lkml/2016/3/24/281
> max_register also needs an appropriate value.
Ok, since the complete set which switches to the atomic helper is not
stable material (and also won't make it into 4.7 anymore), I created a
seperate bugfix now:
https://lists.freedesktop.org/archives/dri-devel/2016-June/109625.html
What I don't quite get yet is the REGCACHE_FLAT influencing the
endianness behavior?
If it is, Meng, can you test again with v4.7-rc1 + the FLAT cache patch
above?
--
Stefan
next prev parent reply other threads:[~2016-06-03 22:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <HE1PR04MB105158F9CB2CEC73E6B5F5E9EC7A0@HE1PR04MB1051.eurprd04.prod.outlook.com>
2016-05-25 2:14 ` fsl-dcu not works on latest "drm-next" Meng Yi
2016-05-25 6:20 ` Stefan Agner
2016-05-25 8:32 ` Alexander Stein
2016-05-25 8:58 ` Meng Yi
2016-05-25 9:57 ` Alexander Stein
2016-05-25 10:25 ` Meng Yi
2016-05-25 12:16 ` Alexander Stein
2016-05-26 8:18 ` Meng Yi
2016-05-26 9:11 ` Alexander Stein
2016-05-25 9:18 ` Mark Brown
2016-05-25 9:59 ` Meng Yi
2016-05-25 10:41 ` Mark Brown
2016-05-26 8:23 ` Meng Yi
2016-05-26 9:11 ` Alexander Stein
2016-05-27 5:54 ` Stefan Agner
2016-05-27 12:20 ` Mark Brown
2016-05-27 17:36 ` Stefan Agner
2016-05-27 19:50 ` Mark Brown
2016-06-03 22:52 ` Stefan Agner [this message]
2016-06-07 2:16 ` Meng Yi
2016-06-07 2:46 ` Stefan Agner
2016-06-07 3:47 ` Meng Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17f0bd63a0efebefb30f10ff208da9bd@agner.ch \
--to=stefan@agner.ch \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=alexander.stein@systec-electronic.com \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meng.yi@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox