From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84BE63054D7 for ; Wed, 26 Nov 2025 14:52:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168754; cv=none; b=cKnVGmgVgo8kE0JGOhleEOw6TUbCEhhRg93xoJ++xc4JxujhyqRJTqQGOifRzsJ0PDnUMxLkpVUWpvUz81r6Pu4KLHXeypo16d5IP6chmd2oJ09qCkBu4dh/sfW2lqDMrxW6XIgk+zNEK6BSIOtUmcB5yK0oo7F/sP5je2HPZUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168754; c=relaxed/simple; bh=X45ZDWDBTw1wxXtkxfMlyBa4vvDgq0JXkYBWXwJNuFY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=vB/vzzrlsTaHQQmYgMDgqlZFbhiSS9uxfEBhMcoh5bgr2oH0OdwofqdlzTIubMok5RfMgLW0r+nm3wYiFII17DTV5V6VQ/UOXH6hQ9pDyn/LpYLoU6D0ryblQjFOFaOtjscsoEUrMLa8vA4VXJUOGuCet0DN8uMBsEq2vafUOT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZlFr5g7p; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZlFr5g7p" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764168752; x=1795704752; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=X45ZDWDBTw1wxXtkxfMlyBa4vvDgq0JXkYBWXwJNuFY=; b=ZlFr5g7pTWGbzxPKI2TC2dR9m/ehnl3JFYqeO02uWhpPckJRXGXq7MDR n+UlfGVl4DppxHup16goF87AX6T72UrSYpZ5gonLbJ5pau57+UqPt09hz 7ZnxvtTvkseiWdbXbqDH5T+mbvOgZi6TVVPiXjOLelwYHThVR5Ff1TxWU 8n7PgXhI5UUlhzAVx+0aa52A/3w57nsS4Gu1nnZtAj042qIE7KnY87oB3 s3v/WG95dlkQzND6B1Kx5yJRZ3Ct72jtIB9FkMwamY7pfMoWb2yEZbDyn tcP+U3HHsi1dkDtNRZz4G01nB+qugwKUMvdyZ91md0socc2Yq5tJdILqH g==; X-CSE-ConnectionGUID: 9yoaW+2sSziOkYvbtj5ZIw== X-CSE-MsgGUID: tTHbJM+bRGeMrWfZ0wQxlA== X-IronPort-AV: E=McAfee;i="6800,10657,11625"; a="68798467" X-IronPort-AV: E=Sophos;i="6.20,228,1758610800"; d="scan'208";a="68798467" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2025 06:52:32 -0800 X-CSE-ConnectionGUID: mEkr9s6eTiqjyMLUyXKzoQ== X-CSE-MsgGUID: ESymxlEkQ0eJE/dZN3E3eg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,228,1758610800"; d="scan'208";a="197286295" Received: from lfiedoro-mobl.ger.corp.intel.com (HELO localhost) ([10.245.246.1]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2025 06:52:26 -0800 From: Jani Nikula To: Yaroslav , Yaroslav Bolyukin , Ville =?utf-8?B?U3lyasOkbMOk?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , Wayne Lin , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v6 4/7] drm/edid: parse DSC DPP passthru support flag for mode VII timings In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20251126065126.54016-1-iam@lach.pw> <20251126065126.54016-5-iam@lach.pw> <6f88c0111ce7f2a74010ff43a77bdd03f669ffb6@intel.com> Date: Wed, 26 Nov 2025 16:52:23 +0200 Message-ID: <17f7e5e7d45bab4324968e352231f739bbdf7366@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, 26 Nov 2025, Yaroslav wrote: > On 2025-11-26 15:19, Jani Nikula wrote: >> On Wed, 26 Nov 2025, Yaroslav Bolyukin wrote: >>> + if (type_7 && FIELD_GET(DISPLAYID_BLOCK_REV, block->rev) >= 1) >>> + mode->dsc_passthrough_timings_support = >>> + !!(block->rev & DISPLAYID_BLOCK_PASSTHROUGH_TIMINGS_SUPPORT); >> >> The !! and parentheses are superfluous. >> > > Most of the other instances of bitflag parsing logic in kernel seem to > cast integers to booleans explicitly this way. > > I'm fine with simplifying that, I was only doing what everyone else does. I get that, but such habits originate from the days before std bool. !! normalizes ints to 0 and 1, but assigning to bool does the same for you. BR, Jani. -- Jani Nikula, Intel