public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Keith Owens <kaos@ocs.com.au>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jamagallon@able.es (J . A . Magallon),
	linux-kernel@vger.kernel.org (linux-kernel)
Subject: Re: Module section warning
Date: Sat, 06 Jan 2001 18:53:05 +1100	[thread overview]
Message-ID: <18121.978767585@ocs3.ocs-net> (raw)
In-Reply-To: Your message of "Fri, 05 Jan 2001 20:51:46 -0000." <E14Edq0-0008PC-00@the-village.bc.nu>

On Fri, 5 Jan 2001 20:51:46 +0000 (GMT), 
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>> o  binutils               2.9.1.0.25              # ld -v
>> o  modutils               2.4.0                   # insmod -V
>> 
>> and 2.4 uses gas instead of as86 for real mode.
>> 
>> Are not that versions enough to delete the
>> __asm__(".section .modinfo\n\t.previous");
>> in module.h ?
>
>Firstly they are guidelines for x86. Secondly certain configs need the updates
>so its pretty invasive to force it yet - 2.5.0 yes

Any modutils >= 2.3.19 automatically treats .modinfo as no load,
irrespective of what the kernel says.  Since modutils 2.3.21 fixes the
local root exploit on modprobe, nobody on kernel 2.4 should be running
modutils < 2.3.21.  I am tempted to put a check in modules_install to
detect insecure modutils and bitch.

Modutils 2.4 is backwards compatible down to 2.0 kernels.  I have no
qualms about removing __asm__(".section .modinfo\n\t.previous"); from
module.h in 2.4 kernels and will be sending in patches to do that,
along with other changes to module.h.  Worst case when omitting that
line and still using old modutils is a slightly larger module in
memory.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

      reply	other threads:[~2001-01-06  7:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-05 20:06 Module section warning J . A . Magallon
2001-01-05 20:51 ` Alan Cox
2001-01-06  7:53   ` Keith Owens [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18121.978767585@ocs3.ocs-net \
    --to=kaos@ocs.com.au \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jamagallon@able.es \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox