From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F180013AA27 for ; Fri, 23 Aug 2024 07:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724396703; cv=none; b=qUDHKarHDmvWbdPryasJvvIsYtGdAbZ0i0EMJhb+y08Yasejd4XHhKeV6DfMO63OiZ3yTISPRNNKO5CrXRfYBgvdflsVbXqQw3EPa21UAzoafOR21csWGETcOhCpHyQ6gdY58Uxp73JhEsoryJa//BBDxX4MuV+htFRYHIaERRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724396703; c=relaxed/simple; bh=vn/ZOdIeoLtOfVc1hGIaG5wGmE3X/icgB5gRwNGeQJ8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=usBtF7BUZznpg5iLmadiVyV4Te5P7GRHCV6mznlGEAJQR5S/5PR9BOunHhYDO2i826MEMvkFXtGJDJy4HgulmdRHA17XJWSxsDMdFk9xfGvKLa9vExUTDrSCNHpW9JKwZkl5fFb8RsZ+u8yeOQFAT2viu5D76s796cnZiUKwlMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=OgzVhv08; arc=none smtp.client-ip=95.215.58.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="OgzVhv08" Message-ID: <18138d48-3758-5aad-1d68-6250687f75f5@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724396698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x2pvmNoBXbC35XP6oZr9MPuOdP6ZuhsCvUKhJSr7VdE=; b=OgzVhv08IpqRpac8IxVAC7nL2KPOffjOR0w72yV/uacOBx71nccJznLWqWb0lMeUOktUki VxQ4Ig25RYfCzdxFpiZvWQ1wyGe2VCvmthXE/CpMFRO66usjGrYd60Wkj22wTD/huLfwib Vq/Gn5YiLoSJtPCE2COB87fHMJlEKcs= Date: Fri, 23 Aug 2024 15:04:48 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] selftests/bpf: Fix incorrect parameters in NULL pointer checking To: Yonghong Song Cc: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Hao Ge , Dan Carpenter , andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, mykolal@fb.com, shuah@kernel.org, jolsa@kernel.org, sdf@fomichev.me, ast@kernel.org, daniel@iogearbox.net References: <20240820023447.29002-1-hao.ge@linux.dev> <02dd26b5-16a0-4732-80e4-c7bf183e965a@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Hao Ge In-Reply-To: <02dd26b5-16a0-4732-80e4-c7bf183e965a@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Hi Yonghong Thank you very much for taking the time to review my patch. On 8/22/24 05:03, Yonghong Song wrote: > > On 8/19/24 7:34 PM, Hao Ge wrote: >> From: Hao Ge >> >> Smatch reported the following warning: >>      ./tools/testing/selftests/bpf/testing_helpers.c:455 >> get_xlated_program() >>      warn: variable dereferenced before check 'buf' (see line 454) >> >> It seems correct,so let's modify it based on it's suggestion. >> >> Actually,commit b23ed4d74c4d ("selftests/bpf: Fix invalid pointer >> check in get_xlated_program()") fixed an issue in the test_verifier.c >> once,but it was reverted this time. >> >> Let's solve this issue with the minimal changes possible. >> >> Reported-by: Dan Carpenter >> Closes: >> https://lore.kernel.org/all/1eb3732f-605a-479d-ba64-cd14250cbf91@stanley.mountain/ >> Fixes: b4b7a4099b8c ("selftests/bpf: Factor out get_xlated_program() >> helper") >> Signed-off-by: Hao Ge > > In the future, please change subject '[PATCH] ...' to '[PATCH > bpf-next] ...' > so CI can properly test it. > OK, I understand. I will follow this rule in the future. > Acked-by: Yonghong Song >