* [PATCH] connector: remove duplicated code in cn_call_callback()
@ 2014-03-01 20:00 Alexey Khoroshilov
2014-03-03 20:39 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Khoroshilov @ 2014-03-01 20:00 UTC (permalink / raw)
To: Evgeniy Polyakov, David S . Miller
Cc: Alexey Khoroshilov, netdev, linux-kernel
There were a couple of patches fixing the same bug that
results in duplicated err = 0; assignment.
The patch removes one of them.
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
drivers/connector/connector.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c
index a36749f1e44a..9b0ea0a6e26e 100644
--- a/drivers/connector/connector.c
+++ b/drivers/connector/connector.c
@@ -139,7 +139,6 @@ static int cn_call_callback(struct sk_buff *skb)
spin_unlock_bh(&dev->cbdev->queue_lock);
if (cbq != NULL) {
- err = 0;
cbq->callback(msg, nsp);
kfree_skb(skb);
cn_queue_release_callback(cbq);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] connector: remove duplicated code in cn_call_callback()
2014-03-01 20:00 [PATCH] connector: remove duplicated code in cn_call_callback() Alexey Khoroshilov
@ 2014-03-03 20:39 ` David Miller
2014-03-03 20:42 ` zbr
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2014-03-03 20:39 UTC (permalink / raw)
To: khoroshilov; +Cc: zbr, netdev, linux-kernel
From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Sun, 2 Mar 2014 00:00:56 +0400
> There were a couple of patches fixing the same bug that
> results in duplicated err = 0; assignment.
> The patch removes one of them.
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Applied to net-next, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] connector: remove duplicated code in cn_call_callback()
2014-03-03 20:39 ` David Miller
@ 2014-03-03 20:42 ` zbr
0 siblings, 0 replies; 3+ messages in thread
From: zbr @ 2014-03-03 20:42 UTC (permalink / raw)
To: David Miller, khoroshilov@ispras.ru
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Hi everyone
04.03.2014, 00:39, "David Miller" <davem@davemloft.net>:
> From: Alexey Khoroshilov <khoroshilov@ispras.ru>
> Date: Sun, 2 Mar 2014 00:00:56 +0400
>
>> There were a couple of patches fixing the same bug that
>> results in duplicated err = 0; assignment.
>> The patch removes one of them.
>>
>> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
>
> Applied to net-next, thank you.
Thank you
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-03 20:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-01 20:00 [PATCH] connector: remove duplicated code in cn_call_callback() Alexey Khoroshilov
2014-03-03 20:39 ` David Miller
2014-03-03 20:42 ` zbr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox