From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753204AbdBTMp7 (ORCPT ); Mon, 20 Feb 2017 07:45:59 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:52289 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669AbdBTMp5 (ORCPT ); Mon, 20 Feb 2017 07:45:57 -0500 X-AuditID: b6c32a35-f79d66d000001a37-1c-58aae26b281a From: Bartlomiej Zolnierkiewicz To: Dmitry Torokhov Cc: "Maciej W. Rozycki" , Tomi Valkeinen , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: remove incorrect __exit markups Date: Mon, 20 Feb 2017 13:34:46 +0100 Message-id: <1817491.0a94zKjNFl@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170213001349.GA1839@dtor-ws> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42LZdlhTVzf70aoIg/k/LS0OL3rBaHGi7wOr xeVdc9gszj9/y2Kxfv4tNgdWj52z7rJ7HF25lsnj+I3tTB6fN8kFsERx2aSk5mSWpRbp2yVw ZZw+0c9Y8EGyYv6bkgbGRtEuRk4OCQETiQ9/9jFC2GISF+6tZ+ti5OIQEtjBKNHz+yQjhNPO JPHz4AlWmI6FbdeZIBJzGCUuTpjBDOF8ZZR4/3sLWBWbgJXExPZVYHNFBPQlts/+BTaKWWAq o8TKiZ/AEsIC1hKvFrQwgdgsAqoSN2f1sYHYvAKaEv9v7gGrERXwktiyrx2ohoODU0BH4uIl LYgSQYkfk++xgNjMAvIS+/ZPZYWwdSTOHlsHtktCoJ9d4lr/TxaQXgkBWYlNB5ghTBeJo6v4 IZ4Rlnh1fAs7hC0tserfLSYIezqjxPbfEhBjNjNKrNo9AarIWuLw8YtQu/gk3n3tYYWYySvR 0SYEUeIhMWNFPxuE7Shx/uhusDOFBOolns5bxT6BUX4Wkg9mIflgFpIPFjAyr2IUSy0ozk1P LTYsMNQrTswtLs1L10vOz93ECE4ZWqY7GKec8znEKMDBqMTD2zB7ZYQQa2JZcWXuIUYJDmYl Ed43l1dFCPGmJFZWpRblxxeV5qQWH2KU5mBREudlNZgYISSQnliSmp2aWpBaBJNl4uCUamCc sH/dopqDb58Ir1f7KLFRa4LQK5aOHe+DJaaoTFo3X3rZaQFRO9bVK8XsPrZzPXEw+xzR9qJT 6G3F/y3ea3qX/X+7miXv2v+O2YWuTIHOh9Vsr/w5eeC25pqgll1JE/wfHjxxVPE1B8cbg5Zt T+/csKnYcYbVq3Wv6MSNzTYlIc0zJlhqb832VWIpzkg01GIuKk4EACtmq0MVAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsVy+t9jQd3sR6siDGb0MFocXvSC0eJE3wdW i8u75rBZnH/+lsVi/fxbbA6sHjtn3WX3OLpyLZPH8RvbmTw+b5ILYIlys8lITUxJLVJIzUvO T8nMS7dVCg1x07VQUshLzE21VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2CW8bpE/2MBR8k K+a/KWlgbBTtYuTkkBAwkVjYdp0JwhaTuHBvPVsXIxeHkMAsRomNPe2MEM5XRonZW/ayglSx CVhJTGxfxQhiiwjoS2yf/QusiFlgKqNEc9taNpCEsIC1xKsFLWBjWQRUJW7O6gOL8wpoSvy/ uQesWVTAS2LLvnagGg4OTgEdiYuXtCCWNTJKPJ29nwWiXlDix+R7YDazgLzEvv1TWSFsLYn1 O48zTWAEuhOhbBaSsllIyhYwMq9ilEgtSC4oTkrPNcxLLdcrTswtLs1L10vOz93ECI6jZ1I7 GA/ucj/EKMDBqMTD2zB7ZYQQa2JZcWXuIUYJDmYlEd43l1dFCPGmJFZWpRblxxeV5qQWH2I0 BXpwIrOUaHI+MMbzSuINTcxNzI0NLMwtLU2MlMR5G2c/CxcSSE8sSc1OTS1ILYLpY+LglGpg 7PVmr1+j/V72iM3NX2IGN0N89/12W5l9+f4nMU5xr96rzkbJ13hNH9SZfDE1abHn2Zz+Kkrl 0haNud+O3twwc/E3oc/fer7J+mSvllTw3CV99lcfy+H+6QqpE5V3xbYnLDru8WB/946Qk3Oa ki5rmz/jMJucw6gmNjttj0bj7LsSG8+azxErUmIpzkg01GIuKk4EAPHEDuK5AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170220123451epcas1p39ba8f2b388ab476fe28f957b8544fe17 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170213001411epcas3p41b3d269696ff8d0ad93cd57ce2d76581 X-RootMTR: 20170213001411epcas3p41b3d269696ff8d0ad93cd57ce2d76581 References: <20170213001349.GA1839@dtor-ws> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sunday, February 12, 2017 04:13:49 PM Dmitry Torokhov wrote: > Even if bus is not hot-pluggable, the devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_driver_probe() which specifically disables sysfs bind/unbind > attributes. Please split your patch on pmag-ba-fb and pmagb-b-fb parts and fix patch subjects while at it ("video: fbdev: pmag-ba-fb: remove incorrect __exit markup" and "video: fbdev: pmagb-b-fb: remove incorrect __exit markup"). > Also pmagb(a|b)fb_erase_cursor() are called from non __init codepaths, > so they should not be marked as __init either. '__init' annotations have already been fixed by Maciej (patches are in fbdev-for-next branch of my tree) so please drop these changes from your patches. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > Signed-off-by: Dmitry Torokhov > --- > drivers/video/fbdev/pmag-ba-fb.c | 6 +++--- > drivers/video/fbdev/pmagb-b-fb.c | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/video/fbdev/pmag-ba-fb.c b/drivers/video/fbdev/pmag-ba-fb.c > index 5872bc4af3ce..1fd02f40708e 100644 > --- a/drivers/video/fbdev/pmag-ba-fb.c > +++ b/drivers/video/fbdev/pmag-ba-fb.c > @@ -129,7 +129,7 @@ static struct fb_ops pmagbafb_ops = { > /* > * Turn the hardware cursor off. > */ > -static void __init pmagbafb_erase_cursor(struct fb_info *info) > +static void pmagbafb_erase_cursor(struct fb_info *info) > { > struct pmagbafb_par *par = info->par; > > @@ -235,7 +235,7 @@ static int pmagbafb_probe(struct device *dev) > return err; > } > > -static int __exit pmagbafb_remove(struct device *dev) > +static int pmagbafb_remove(struct device *dev) > { > struct tc_dev *tdev = to_tc_dev(dev); > struct fb_info *info = dev_get_drvdata(dev); > @@ -270,7 +270,7 @@ static struct tc_driver pmagbafb_driver = { > .name = "pmagbafb", > .bus = &tc_bus_type, > .probe = pmagbafb_probe, > - .remove = __exit_p(pmagbafb_remove), > + .remove = pmagbafb_remove, > }, > }; > > diff --git a/drivers/video/fbdev/pmagb-b-fb.c b/drivers/video/fbdev/pmagb-b-fb.c > index 0822b6f8dddc..46e96c451506 100644 > --- a/drivers/video/fbdev/pmagb-b-fb.c > +++ b/drivers/video/fbdev/pmagb-b-fb.c > @@ -133,7 +133,7 @@ static struct fb_ops pmagbbfb_ops = { > /* > * Turn the hardware cursor off. > */ > -static void __init pmagbbfb_erase_cursor(struct fb_info *info) > +static void pmagbbfb_erase_cursor(struct fb_info *info) > { > struct pmagbbfb_par *par = info->par; > > @@ -353,7 +353,7 @@ static int pmagbbfb_probe(struct device *dev) > return err; > } > > -static int __exit pmagbbfb_remove(struct device *dev) > +static int pmagbbfb_remove(struct device *dev) > { > struct tc_dev *tdev = to_tc_dev(dev); > struct fb_info *info = dev_get_drvdata(dev); > @@ -388,7 +388,7 @@ static struct tc_driver pmagbbfb_driver = { > .name = "pmagbbfb", > .bus = &tc_bus_type, > .probe = pmagbbfb_probe, > - .remove = __exit_p(pmagbbfb_remove), > + .remove = pmagbbfb_remove, > }, > };