From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 397BEC4338F for ; Sun, 22 Aug 2021 11:12:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B308610FF for ; Sun, 22 Aug 2021 11:12:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233290AbhHVLGz (ORCPT ); Sun, 22 Aug 2021 07:06:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232822AbhHVLGy (ORCPT ); Sun, 22 Aug 2021 07:06:54 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4121FC061575 for ; Sun, 22 Aug 2021 04:06:13 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id bt14so30445056ejb.3 for ; Sun, 22 Aug 2021 04:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J/K1zJt9K2vM4YNNzqxi4TbMv+urfoGymzw1sNlJiRY=; b=AX55T5qy7NO40os7OlBFpccap583qZZmZt4H4RNz41wp2sjxm0BQdKU8VJ1dyE21aM 4l27B2JJsOt0eL+0Cie02TTqnEs1b0WGNPKLIgNM2j8FHDtLUV6m4729HjDbmcuNh2tT p/l+dqSYDPEUfRbC1Fp9QsQSwQ5mzWSXuvAD72/LzVDRrjBSoUQc7EXH3vUUfztNQYQk jx24P8gwXO5bT33pMIbCOD4TT8IlrZCxQbpXB9JTcKTS30zlRDOpuRzSbgbRmg0flqZk NbyHmVHONiTeNk1Hs4GMm9B0GXswMRdxoB7C5CIv6SqkFPzcdsAB1q3C9BuQLvaqSRTd MM3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J/K1zJt9K2vM4YNNzqxi4TbMv+urfoGymzw1sNlJiRY=; b=IeL0rnhfCkA6V9j4yNoE+/NLpkBfTcVyf0g1yMETkWeanANcp2AAwYUbSF2qy/487+ vWVKDgbJa/xy8D5BGVHO7LI9+ORSZ2xp3ZiC1mMKeVmd3QskydseQjLzd/uxlPL8LdP6 3LWZcp/yJVwFvUJYaxToye+iPAKkrcXilr7u+v7U1cqQoJgwsgSVIJ/z30IK8rcqYC5g aZOKESCNmkeaJdhLxldJNMcb8pBM1UXqVk1qNyYV+Iwvs7oJJ3bsxOgVvYdHinOCxSjI EMRD1oBkWeBXj2vjfQlIjXqKHR8nnt9Apoe8IZekvKBXozOHA/xKeURs9IwYJ65AqpZM dt/g== X-Gm-Message-State: AOAM533qb6JR9iWG+0o7La9kBI20ED8Kdw/vGvynVcvRxbA/CYjKGGtP PxfYujFor903wuN5lezJ4Ic= X-Google-Smtp-Source: ABdhPJwNyBU6A/Uc3oCrD+++ujwNXshWTb90/l4LeX9WrRGPjk2SOwIQsxCGb1MDnAtD10kk4CpyQQ== X-Received: by 2002:a17:906:eb53:: with SMTP id mc19mr30478652ejb.22.1629630371782; Sun, 22 Aug 2021 04:06:11 -0700 (PDT) Received: from localhost.localdomain (host-79-22-100-164.retail.telecomitalia.it. [79.22.100.164]) by smtp.gmail.com with ESMTPSA id g10sm5580146ejj.44.2021.08.22.04.06.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Aug 2021 04:06:11 -0700 (PDT) From: "Fabio M. De Francesco" To: Saurav Girepunje , Phillip Potter Cc: Larry Finger , Greg KH , linux-staging@lists.linux.dev, Linux Kernel Mailing List , saurav.girepunje@hotmail.com Subject: Re: [PATCH] staging: r8188eu: core: remove condition with no effect Date: Sun, 22 Aug 2021 13:06:09 +0200 Message-ID: <1821445.fzUCeO1EU3@localhost.localdomain> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, August 22, 2021 1:58:10 AM CEST Phillip Potter wrote: > On Sat, 21 Aug 2021 at 21:23, Saurav Girepunje > > wrote: > > Remove the condition with no effect (if == else) in rtw_led.c > > file. > > > > Signed-off-by: Saurav Girepunje > > --- > > > > drivers/staging/r8188eu/core/rtw_led.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > Thanks for this, looks good. > > Acked-by: Phillip Potter > > Regards, > Phil Dear Philip, Before acking, please check at least if it applies to the current version of the tree and check if it compiles without adding warnings and / or errors. :-) Thanks, Fabio