Re: [PATCH] VFS autmounter support

viro
2003-06-18T04:56:40Z

On Tue, Jun 17, 2003 at 09:55:17PM -0700, Linus Torvalds wrote:
>
> On Tue, 17 Jun 2003, David Howells wrote:
> >
> > The attached patch adds automounting support and mountpount expiry support to
> > the VFS.
>
> I don't think this is evil, but it looks a bit non-appropriate for now.
> But I'd like to see Al's (and others) comments on it..

I'm not too happy with it. If nothing else, IMO it's the wrong way to
solve the problem - if you want a bunch of filesystems look like a
single object (i.e. go together wherever we mount it, etc.), make it
a filesystem. That would make a lot of sense, and not only for AFS.

We need a light-weight automount. No arguments here. But it should
be per-namespace - i.e. "I want to have <foo> mounted on /usr/barf on
demand and I have no intention to screw somebody else - somebody who
might have the same directory seen as /usr/local/debian/barf and want
<blah> mounted on demand there".

Namespace is controled by owner of that namespace. It is a security
boundary, among other things. And events in one namespace should not
cause mounts in another. Yes, AFS wants an illusion of single filesystem
composed in fixed way from many pieces. But if you want to do that,
do it right - make sure that it acts as a single chunk in mount tree.
IOW, make it look like a single filesystem.