From: Neil Brown <neilb@suse.de>
To: "J. Bruce Fields" <bfields@citi.umich.edu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: nfsd bugfixes
Date: Tue, 13 Nov 2007 09:08:42 +1100 [thread overview]
Message-ID: <18232.52970.213438.902011@notabene.brown> (raw)
In-Reply-To: message from J. Bruce Fields on Monday November 12
On Monday November 12, bfields@citi.umich.edu wrote:
> The following two patches are nfsd bugfixes that I believe are
> appropriate for 2.6.24 and 2.6.23.y.
>
> --b.
>
Both
Reviewed-By: NeilBrown <neilb@suse.de>
Calling nfsd_setuser an extra time does open us up for a very tiny
possibility of an ENOMEM at an awkward time.
We could remove that entirely for NFSEXP_ALLSQUASH by allocating an
empty group_info at export time and just using a reference to that.
It would be more awkward to pre-allocate for the NFSEXP_ROOTSQUASH
case as the group_info has to be at least as big as the one in the RPC
request, and would could need a different one of each concurrent
request.... not sure if that is worth "fixing".
Thanks,
NeilBrown
next prev parent reply other threads:[~2007-11-12 22:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-12 21:05 nfsd bugfixes J. Bruce Fields
2007-11-12 21:05 ` [PATCH] knfsd: fix spurious EINVAL errors on first access of new filesystem J. Bruce Fields
2007-11-12 21:05 ` [PATCH] nfsd4: recheck for secure ports in fh_verify J. Bruce Fields
2007-11-12 22:08 ` Neil Brown [this message]
2007-11-12 22:13 ` nfsd bugfixes J. Bruce Fields
2007-11-12 22:35 ` Neil Brown
2007-11-12 23:17 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18232.52970.213438.902011@notabene.brown \
--to=neilb@suse.de \
--cc=bfields@citi.umich.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox