From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964840AbcBILOy (ORCPT ); Tue, 9 Feb 2016 06:14:54 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:59991 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932932AbcBILOv convert rfc822-to-8bit (ORCPT ); Tue, 9 Feb 2016 06:14:51 -0500 From: Arnd Bergmann To: Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: Greg Ungerer , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: ks8695: fix __initdata annotation Date: Tue, 09 Feb 2016 12:14:15 +0100 Message-ID: <18237653.x9qPaNvtCU@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160209090030.GS13664@pengutronix.de> References: <1454941509-2773774-1-git-send-email-arnd@arndb.de> <20160209090030.GS13664@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" X-Provags-ID: V03:K0:1k+YAIXCythXQWSuTFS6NyZ92SK3mSzohEmrTN/H8Aj3drChxbm zkGOLd9WSMhXBAElXIFF6VfDvnTPI+Xu/bzq7XY1c01Xi35szMTnRg04g8OQxCzeJq9V91B l9QY41sOut/CwF6zixh9IpCLT7foXJ+37D87QAxzfWVjoZ+B39sBW5JVB0WNzqTxc0YgL0G UAZR/pIBex3Ql2DY8iVGQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:FWdEi2mem+Q=:vUdBlrKEtRS4teHLlqYZFk fTZv+O4LbJtbRp5LXBgslYAqebX3UX39vT4JIWyTfIu6E2ZYEaUVE9KlpQn+WVhTgvBl33Agz THikBZ6IkG8LjfBpzj6BZJuS1oavZvN1go9pmwKrTmGFWXCnZQkK5P9dyzwy0inSRDJiV9JyY tFH5dbfDWjrEgJOoN1NFNO152ZJwda767CkBWdyvyzgOf1DVrczv2jpkjTiYuiYFWCV9eTckl BYQ9j9swuS9OR5t/gZiDymsE0m8fd+2oEo4fuy4rdJP6vsm4d/QwWFwj0jfRMFWvnx0c49F1+ BNFmktaSHFmxAYdGA7vJUJ2AKGP+T1b5LwO3C2r1zujip3Ii5jgvU9AmdzBSaGq/AsE1bSChN o8NITFBgxujV6UaL3zGAWMR8UfZd3qkC7Y3i+HQmhHeNtEqS/6cEvyLw7QKHmBzbEQzrvZ32w dZLbgHAZ3KmChUZ1ENFCxlUicm+DoptJ/M6GkbWDF7t3jEOk7JzKPeovlidrisDj3Lw91RAdI VgCZGgNCmookLSbCn0uBQizPSnwmkPmKicjpPVXXvmi5tGuKtr9cy0PfUskELW4hJAOxgauwd xgVBSzXHiK7zJAWDpH/gjgU9JoOrN4W23KW88lzA8gZ2blWaaO6W9doZx5NWJjmbTffUG6oBr oEBiOaFPOviNIxtP1CsuXyrYl9vXHCAKPm1dOsK4KCZvJvCUpx+fOuN0TQtevrltCndYRUQMQ n1wDG4f06rs9kpad Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 09 February 2016 10:00:30 Uwe Kleine-König wrote: > > diff --git a/arch/arm/mach-ks8695/board-og.c b/arch/arm/mach-ks8695/board-og.c > > index 1f4f2f4f25bb..fa1a7c2ca2bb 100644 > > --- a/arch/arm/mach-ks8695/board-og.c > > +++ b/arch/arm/mach-ks8695/board-og.c > > @@ -80,7 +80,7 @@ static void __init og_pci_bus_reset(void) > > #define S8250_VIRT 0xf4000000 > > #define S8250_SIZE 0x00100000 > > > > -static struct __initdata map_desc og_io_desc[] = { > > +static struct map_desc __initdata og_io_desc[] = { > > I would have expected that > > +static struct map_desc og_io_desc[] __initdata = { > > is the correct variant? > I think those two mean the exact same thing, and we have tons of examples for either one in the kernel, unlike the one I removed. I have verified that the resulting object files are identical. Can you point me to some documentation that clarifies which one to use, and why? Arnd