Re: [PATCH] [media] media/v4l2: VIDEO_RENESAS_VSP1 should depend on HAS_DMA

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Geert,

On Friday 06 September 2013 19:07:50 Geert Uytterhoeven wrote:
> On Fri, Sep 6, 2013 at 5:20 PM, Laurent Pinchart wrote:
> > On Friday 06 September 2013 14:43:56 Geert Uytterhoeven wrote:
> >> If NO_DMA=y:
> >> 
> >> warning: (... && VIDEO_RENESAS_VSP1 && ...) selects VIDEOBUF2_DMA_CONTIG
> >> which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA)
> >> 
> >> drivers/media/v4l2-core/videobuf2-dma-contig.c: In function
> >> ‘vb2_dc_mmap’:
> >> drivers/media/v4l2-core/videobuf2-dma-contig.c:202: error: implicit
> >> declaration of function ‘dma_mmap_coherent’
> >> drivers/media/v4l2-core/videobuf2-dma-contig.c: In function
> >> ‘vb2_dc_get_base_sgt’:
> >> drivers/media/v4l2-core/videobuf2-dma-contig.c:385:
> >> error: implicit declaration of function ‘dma_get_sgtable’ make[7]: ***
> >> [drivers/media/v4l2-core/videobuf2-dma-contig.o] Error 1
> >> 
> >> VIDEO_RENESAS_VSP1 (which doesn't have a platform dependency) selects
> >> VIDEOBUF2_DMA_CONTIG, but the latter depends on HAS_DMA.
> >> 
> >> Make VIDEO_RENESAS_VSP1 depend on HAS_DMA to fix this.
> > 
> > Is there a chance we could fix the Kconfig infrastructure instead ? It
> > warns about the unmet dependency, shouldn't it disallow selecting the
> > driver in the first place ? I have a vague feeling that this topic has
> > been discussed before though.
> 
> This has come up several times before.
> Unfortunately "select" was "designed" to circumvent all dependencies of
> the target symbol.

I suppose that fixing this "design bug" (or feature, depending on how one sees 
it) has been discussed extensively in the past and that the behaviour will not 
change in the near future.

I'll take your patch in and push it to v3.12.

> > If that's not possible,
> > 
> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > 
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart