From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755598AbZHDPkY (ORCPT ); Tue, 4 Aug 2009 11:40:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755449AbZHDPkX (ORCPT ); Tue, 4 Aug 2009 11:40:23 -0400 Received: from mx2.redhat.com ([66.187.237.31]:50656 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755096AbZHDPkW (ORCPT ); Tue, 4 Aug 2009 11:40:22 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20090804151747.GA3698@us.ibm.com> References: <20090804151747.GA3698@us.ibm.com> <20090804145530.17676.24656.stgit@warthog.procyon.org.uk> <20090804145535.17676.87650.stgit@warthog.procyon.org.uk> To: "Serge E. Hallyn" Cc: dhowells@redhat.com, torvalds@osdl.org, akpm@linux-foundation.org, jmorris@namei.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH 2/6] KEYS: Allow keyctl_revoke() on keys that have SETATTR but not WRITE perm Date: Tue, 04 Aug 2009 16:38:26 +0100 Message-ID: <18269.1249400306@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Serge E. Hallyn wrote: > Code seems to match the comment, and I see no docs saying this (SETATTR > implies revoke) shouldn't be the case, so I guess that call is purely > up to you :) Without this, you can't revoke keys that don't have an update method. David