From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757753AbdKOLOr (ORCPT <rfc822;w@1wt.eu>);
        Wed, 15 Nov 2017 06:14:47 -0500
Received: from mail.sigma-star.at ([95.130.255.111]:45996 "EHLO
        mail.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757734AbdKOLOn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Nov 2017 06:14:43 -0500
From: Richard Weinberger <richard@nod.at>
To: Krzysztof Mazur <krzysiek@podlesie.net>
Cc: Jeff Dike <jdike@addtoit.com>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] um: use POSIX ucontext_t instead of struct ucontext
Date: Wed, 15 Nov 2017 12:15:00 +0100
Message-ID: <1828554.ETQJSmL9mu@blindfold>
In-Reply-To: <20171115110416.GA29538@shrek.podlesie.net>
References: <20171115101239.4882-1-krzysiek@podlesie.net> <1518438.KRCSCszYuI@blindfold> <20171115110416.GA29538@shrek.podlesie.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Mittwoch, 15. November 2017, 12:04:16 CET schrieb Krzysztof Mazur:
> On Wed, Nov 15, 2017 at 11:19:41AM +0100, Richard Weinberger wrote:
> > Am Mittwoch, 15. November 2017, 11:12:39 CET schrieb Krzysztof Mazur:
> > > glibc 2.26 removed the 'struct ucontext' to "improve" POSIX compliance
> > > and break programs, including User Mode Linux. Fix User Mode Linux
> > > by using POSIX ucontext_t.
> > > 
> > > This fixes:
> > > 
> > > arch/um/os-Linux/signal.c: In function 'hard_handler':
> > > arch/um/os-Linux/signal.c:163:22: error: dereferencing pointer to
> > > incomplete type 'struct ucontext' mcontext_t *mc = &uc->uc_mcontext;
> > > arch/x86/um/stub_segv.c: In function 'stub_segv_handler':
> > > arch/x86/um/stub_segv.c:16:13: error: dereferencing pointer to
> > > incomplete
> > > type 'struct ucontext' &uc->uc_mcontext);
> > 
> > Do all older glibcs have ucontext_t?
> > Otherwise this patch will break other stuff.
> 
> Yes, ucontext_t typedef was always available. They changed:
> 
> typedef struct ucontext { ... } ucontex_t;
> 
> to
> 
> typedef struct ucontext_t { ... } ucontex_t;
> 
> https://sourceware.org/glibc/wiki/Release/2.26#Removal_of_.27struct_ucontext
> .27

Okay, then we can mark your patch as stable and hope for the best. ;-)

Thanks,
//richard